chore(rustfmt): format let-chains and let-else #9409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haha |
xxchan
changed the title
|
format let-chains first, |
1 task
Codecov Report
@@ Coverage Diff @@
## main #9409 +/- ##
==========================================
- Coverage 70.73% 70.73% -0.01%
==========================================
Files 1233 1233
Lines 206503 206688 +185
==========================================
+ Hits 146079 146198 +119
- Misses 60424 60490 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xxchan
commented
Apr 24, 2023
Comment on lines
+54
to
+62
| let new_left = if let Some(project) = left.as_logical_project() | ||
| && left_input_index_on_condition | ||
| .iter() | ||
| .all(|index| project.exprs()[*index].as_input_ref().is_some()) | ||
| && join_type != JoinType::RightAnti | ||
| && join_type != JoinType::RightSemi | ||
| && join_type != JoinType::RightOuter | ||
| && join_type != JoinType::FullOuter | ||
| { |
There was a problem hiding this comment.
wow 😲 Is this our largest let chain?
xxchan
commented
Apr 24, 2023
Comment on lines
+55
to
+65
| if let Some(hop) = left.as_logical_hop_window() | ||
| && left_input_index_on_condition.iter().all(|&index| { | ||
| hop.output_window_start_col_idx() | ||
| .map_or(true, |v| index != v) | ||
| && hop.output_window_end_col_idx().map_or(true, |v| index != v) | ||
| }) | ||
| && join_type != JoinType::RightAnti | ||
| && join_type != JoinType::RightSemi | ||
| && join_type != JoinType::RightOuter | ||
| && join_type != JoinType::FullOuter | ||
| { |
|
Should I wait for the holiday to merge it? 😄 |
TennyZhuang
approved these changes
Apr 24, 2023
xxchan
force-pushed
the
xxchan/sharp-marlin
branch
from
39dbc3b to
9f114c9
Compare
xxchan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Cherry-pick and test rust-lang/rustfmt#5203 and rust-lang/rustfmt#5690
Use this branch rust-lang/rustfmt@master...xxchan:rustfmt:xxchan/cherry
install
invoke
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note