Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sub level): insert sub level into correct pos in HummockVersion #9600

Merged
merged 6 commits into from
May 8, 2023

Conversation

soundOfDestiny
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist For Contributors

  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #9600 (39a0063) into main (cb922ea) will increase coverage by 0.00%.
The diff coverage is 81.96%.

@@           Coverage Diff           @@
##             main    #9600   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files        1238     1238           
  Lines      207520   207540   +20     
=======================================
+ Hits       147125   147140   +15     
- Misses      60395    60400    +5     
Flag Coverage Δ
rust 70.89% <81.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck_sdk/src/compaction_group/hummock_version_ext.rs 90.86% <81.35%> (-0.39%) ⬇️
src/meta/src/hummock/manager/mod.rs 71.77% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. Thanks for the PR.

}
l0.sub_levels.len()
};
#[cfg(debug_assertions)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this operation happen very frequently? If not I think we can also enable the assertion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this operation happen very frequently? If not I think we can also enable the assertion.

cc @Little-Wallace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is infrequent, the granularity of move table is minute level

@soundOfDestiny soundOfDestiny added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 6b4ac9f May 8, 2023
@soundOfDestiny soundOfDestiny deleted the zl_fix_level branch May 8, 2023 03:34
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort

Li0k

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants