Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support show indexes #9835

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented May 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example

dev=> show indexes from sbtest1;
 Name |   On    |      Key      | Include | Distributed By
------+---------+---------------+---------+----------------
 k_1  | sbtest1 | k ASC, id ASC | c, pad  | k
 ck_1 | sbtest1 | k ASC, id ASC | c, pad  | k
(2 rows)

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

  • Support SHOW INDEXES FROM t.

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label May 16, 2023
@chenzl25 chenzl25 requested a review from yezizp2012 May 16, 2023 08:37
@github-actions github-actions bot added type/feature and removed user-facing-changes Contains changes that are visible to users labels May 16, 2023
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #9835 (3d2e357) into main (59c6165) will decrease coverage by 0.03%.
The diff coverage is 36.15%.

@@            Coverage Diff             @@
##             main    #9835      +/-   ##
==========================================
- Coverage   71.03%   71.01%   -0.03%     
==========================================
  Files        1247     1247              
  Lines      208418   208510      +92     
==========================================
+ Hits       148055   148067      +12     
- Misses      60363    60443      +80     
Flag Coverage Δ
rust 71.01% <36.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/show.rs 32.15% <0.00%> (-4.73%) ⬇️
src/frontend/src/handler/util.rs 78.64% <0.00%> (-9.91%) ⬇️
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
src/sqlparser/src/parser.rs 86.73% <66.66%> (-0.02%) ⬇️
src/frontend/src/handler/describe.rs 76.12% <71.42%> (-3.98%) ⬇️
src/frontend/src/catalog/index_catalog.rs 79.05% <100.00%> (+7.49%) ⬆️
src/sqlparser/src/ast/mod.rs 85.92% <100.00%> (+0.01%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenzl25 chenzl25 added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 9dc057a May 16, 2023
@chenzl25 chenzl25 deleted the dylan/support_show_indexes branch May 16, 2023 09:20
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support command: SHOW INDEXES
4 participants