Fix MusicXML diminuendo <wedge> spread handling #3446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MusicXML standard specifies that the
spread
attribute at the start of a crescendo and the end of a diminuendo is ignored. However, the current code only readsspread
at the end of a<wedge>
pair, which means it handles the spread of diminuendos wrongly.This fix changes the behavior of
MusicXmlInput
so it sets the opening of a hairpin at the end for diminuendos or the start for crescendos. The followings show the result of this fix. Test MusicXML files are made by modifying<wedge>
elements inBeetAnGeSample.musicxml
from the example set on musicxml.com.test-narrow-wedge.musicxml
(Made by replacingspread="15"
withspread="5"
)test-spread-0-at-dim-stop.musicxml
(Made by addingspread="0"
to the end<wedge>
of diminuendos)