Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List with all songs which are not in any playlist #25

Open
Kradus opened this issue Apr 22, 2021 · 6 comments
Open

List with all songs which are not in any playlist #25

Kradus opened this issue Apr 22, 2021 · 6 comments
Assignees

Comments

@Kradus
Copy link

Kradus commented Apr 22, 2021

Hi,
I like this plugin very much and used it to categorize my songs. But in the moment I miss a feature. I would like to have a list with all songs which are not in any playlist. In the moment I must search throw my 100 of songs for the new songs so that I can move every song to the right list and miss no songs.

@rithik-b
Copy link
Owner

Hmm this sounds like something a song filter mod like SomgBrowser should do as my mod doesn't interact with custom songs directly in any way. It would be better if you ask the author of SongBrowser if they're interested.

@rithik-b rithik-b reopened this Apr 22, 2021
@rithik-b
Copy link
Owner

After some discussion with other members of the modding community, I think I can take this feature!

@Kradus
Copy link
Author

Kradus commented Apr 23, 2021

Ok thank you very much.

@rithik-b rithik-b self-assigned this Apr 23, 2021
@kuba2k2
Copy link

kuba2k2 commented Feb 27, 2022

Hi,
I think I have an idea of how could this be implemented, in terms of UX. This would adapt to more use cases.
I, for example, would like to have a playlist "mod charts" to put all modded maps into. There could be a per-playlist toggle "Hide from main list" which would hide all the modcharts from the root playlist - because I know exactly where to look for them, if I want to play.
On the other hand, let's say I have a playlist "BeatSaver top 100 songs" which probably contains many songs I have been playing previously. And I don't want this particular playlist to "steal" my songs from the main list, so I leave the toggle switch off.

If you're not working on this yet, I could try to implement this feature somehow, and put it in a PR.

@rithik-b
Copy link
Owner

Thanks, my main issue rn to implement this isn't UX, but rather performance
Ideally I would want to make a data structure that would link songs to all the playlists it's in to do more with that in the future. If that is empty, the song is in no playlist. Sounds simple right?
The issue is I am using BeatSaberPlaylistsLib for all the I/O and data structures for playlists. So I would need to store this cache there and update it as songs are looked up then added and removed from playlists. I also want to make this toggleable so you can free up memory if you don't want to use this feature.
The issue is BeatSaberPlaylistsLib has no config, so this setting needs to be stored in PlaylistManager (and subsequently be toggled by PlaylistManager in BeatSaberPlaylistsLib). However if a public flag is placed there, BeatSaberPlaylistsLib's setting can be changed by other mods, maliciously or accidentally.
As for UX, I'm waiting on BetterSongList's author to make custom filters in his mod, so PlaylistManager can register a "not in any playlist" filter. Once that is done, I'll try to do the research on how to implement the feature cleanly. Sorry for the delay!

@kuba2k2
Copy link

kuba2k2 commented Feb 27, 2022

Okay, makes sense. So BetterSongList would be a "frontend" to the filters PM creates? If so, you can consider also implementing something like I described above. As for data structures, I think it would be less of a pain. As the feature would be toggleable per-playlist, only the playlists with this enabled could have all their songs added to a "filter list". And all songs from this list would be just filtered out using BetterSongList's custom filter.

Still, I would very much prefer to have it hide songs from the main custom level list, as this is the most frequently used place. Having the data structures already in PM, would it be possible to implement both of these features? I.e. hiding songs with a filter, and optionally hiding songs automatically from the root list.

nicoco007 pushed a commit to nicoco007/PlaylistManager that referenced this issue Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants