-
Notifications
You must be signed in to change notification settings - Fork 82
completed tests and functions #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wavegxd
wants to merge
11
commits into
rithmschool:master
Choose a base branch
from
wavegxd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c43df7c
completed tests and functions
wavegxd 3cd9d0e
still working on bonus questions
wavegxd afc12b5
still working on more functions
wavegxd ff7834c
still need to finish arrow keys
wavegxd a5ca538
finished, used solution to help me with else if statement in the eve…
wavegxd 2133d78
basic requirements, still working on design
wavegxd 41c3644
finished remaining basic problems
wavegxd 23458e3
initial commit
wavegxd b0db5e7
progress
wavegxd 3af2217
initial commit
wavegxd 32c7dc1
finished
wavegxd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| function productOfArray(arr) { | ||
| if (arr.length === 0) return 1; | ||
| return arr[0] * productOfArray(arr.splice(1)); | ||
| } | ||
|
|
||
| function collectStrings(obj) { | ||
| var newArray = []; | ||
| function helper(myObj) { | ||
| for (var key in myObj) { | ||
| if (typeof myObj[key] === 'object') { | ||
| helper(myObj[key]); | ||
| } | ||
| else { | ||
| newArray.push(myObj[key]); | ||
| } | ||
| } | ||
| } | ||
| helper(obj); | ||
| return newArray; | ||
| } | ||
|
|
||
| function contains(obj, src) { | ||
| var isFound = false; | ||
| for (var key in obj) { | ||
| if (typeof obj[key] === 'object') { | ||
| isFound = contains(obj[key], src); | ||
| } | ||
| else if (obj[key] === src) { | ||
| return true; | ||
| } | ||
| if (isFound) return true; | ||
| } | ||
| return false; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| function replaceWith(str, char, replaced) { | ||
| return str.split(char).join(replaced); | ||
| } | ||
|
|
||
| function expand(array, num) { | ||
| var newArray = []; | ||
| for (var i = 0; i < num; i++) { | ||
| for(var j = 0; j < array.length; j++) { | ||
| newArray.push(array[j]); | ||
| } | ||
| } | ||
| return newArray; | ||
| } | ||
|
|
||
| function acceptNumbersOnly() { | ||
| var isTrue = true; | ||
| for (var i = 0; i < arguments.length; i++) { | ||
| if (arguments[i] === parseInt(arguments[i])) { | ||
| isTrue = isTrue && true; | ||
| } | ||
| else isTrue = false; | ||
|
|
||
| } | ||
| return isTrue; | ||
| } | ||
|
|
||
| function mergeArrays(array1, array2) { | ||
| var newArray = array1.concat(array2); | ||
| return newArray.sort(function(a, b) { | ||
| return a - b; | ||
| }); | ||
| } | ||
|
|
||
| function mergeObjects(obj1, obj2) { | ||
| for (var key in obj2) { | ||
| if (obj2.hasOwnProperty(key)){ | ||
| obj1[key] = obj2[key]; | ||
| } | ||
| } | ||
| return obj1; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than produce a random number in each if statement, save the result as a variable outside of the if.