-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed /member not giving Member role and added more response messages #137
Merged
c0untingNumbers
merged 15 commits into
main
from
128-just-verified-members-not-getting-the-role
Sep 7, 2024
Merged
Fixed /member not giving Member role and added more response messages #137
c0untingNumbers
merged 15 commits into
main
from
128-just-verified-members-not-getting-the-role
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
c0untingNumbers
commented
Sep 7, 2024
- Preserved the the original interaction to be passed into the addMemberRole()
- Removed first message function
- Added a reminder to check spam in the verification code message
- Added missing defer delete for alumniSlug
- Added a debug message when all of the initialization is done after bot startup for QoL
bootsie123
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Hopefully this finally fixes it! 🤞
c0untingNumbers
deleted the
128-just-verified-members-not-getting-the-role
branch
September 7, 2024 22:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.