Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

134 adding the ability to query the amount of signins for a member #145

Merged
merged 4 commits into from
Oct 18, 2024
Merged

134 adding the ability to query the amount of signins for a member #145

merged 4 commits into from
Oct 18, 2024

Conversation

oms125
Copy link
Collaborator

@oms125 oms125 commented Oct 18, 2024

Adds /attendanceof <@user> command to check other users' attendance record.
Command permission limited to IGLead role +.

@oms125 oms125 requested a review from a team as a code owner October 18, 2024 17:12
@oms125 oms125 linked an issue Oct 18, 2024 that may be closed by this pull request
Adding the ability to query the amount of signins for a member #134
Closed
c0untingNumbers
c0untingNumbers previously requested changes Oct 18, 2024
View reviewed changes
commands/slash/attendanceof.go Show resolved Hide resolved
@c0untingNumbers c0untingNumbers dismissed their stale review October 18, 2024 17:29

github skill issue

c0untingNumbers
c0untingNumbers approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@c0untingNumbers c0untingNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@c0untingNumbers c0untingNumbers merged commit 39ccf1f into main Oct 18, 2024
4 checks passed
c0untingNumbers
c0untingNumbers reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@c0untingNumbers c0untingNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can change this actually, that would be great then that should be it from what I can see.

commands/slash/attendanceof.go Show resolved Hide resolved
@c0untingNumbers c0untingNumbers mentioned this pull request Oct 20, 2024
Merged
c0untingNumbers pushed a commit that referenced this pull request Nov 1, 2024
@oms125 @c0untingNumbers
134 adding the ability to query the amount of signins for a member (#145
aab06e6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0untingNumbers c0untingNumbers c0untingNumbers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding the ability to query the amount of signins for a member
2 participants
@oms125 @c0untingNumbers