-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 add stack account self service features #150
135 add stack account self service features #150
Conversation
Gophercloud package does not seem to have a good way to get the ID of the member role so I decided that the ID of the member role shall be provided in the config. I will do more investigating on this eventually but I did go pretty deep in the rabbit hole and came out of it with nothing. |
I did see there is a way to get a list of roles which you could query through in order to find the ID. You may also be able to specify the role name instead of the ID. I know with both Terraform and the Openstack CLI that those are interchangeable. I'm not sure if that's because of the Openstack API itself or just because of how Terraform and the CLI are implemented. Either way though, specifying it as a config option is a great solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Fantastic work with this @c0untingNumbers!!! 🔥🔥🔥 🎉🎉🎉
Yes, I actually did try the ones listed in the docs. It actually grabs the ID of the domain "default" instead of the member role. The ID for the member is not even listed. The name of the role which is "member" is only listed. The actual member role ID in the terminal is hard coded for comparison. But, again, I will look into it. |
Huh. Yeah, I see what you mean. That's weird |
Not gonna merge yet, might do some last minute considerations for timeout to prevent reset spamming as well as a new command to allow members to add their email to the database as running /member again does not really give you that option. |
Reset spamming prevention and a verification that is separate from /member are fully implemented now. But I am considering refactoring /member to have the mechanisms of the /verify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @c0untingNumbers!!!!!! 🎉🎉🎉🎉🎉🎉🎉🎉
Once merged and deployed, you may do the honors of making the official announcement! Let me know if you'd rather I do it.
Once again, great work! The entire club is going to be thrilled!
Things to update locally once this is merged: