Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular galaxy #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kousikr26
Copy link

No description provided.

@ritwik12
Copy link
Owner

@kousikr26 Thanks for the PR but this includes some images of comets as well. I guess you are creating branches from other branches only. You should keep a branch clean such as "master" to create as many new branches for all the Different PRs unrelated to each other.

@ritwik12 ritwik12 added the enhancement New feature or request label Oct 28, 2019
@kousikr26
Copy link
Author

@ritwik12 sorry about that removed it now and added the necessary code, please review

@ritwik12
Copy link
Owner

ritwik12 commented Nov 4, 2019

@kousikr26 Can you please add few test data also for this?

Copy link
Owner

@ritwik12 ritwik12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update hub/examples/image_retraining/display_info.yml for the same

@kousikr26
Copy link
Author

@ritwik12 What info should I put in the display_info.yml file for an irregular galaxy as there is no such quantitative data about them. I didn't add anything as there was no entry in it for spiral and elliptical galaxy also.

@ritwik12
Copy link
Owner

ritwik12 commented Nov 4, 2019

@kousikr26 Not needed in that case, we should have an issue for adding display info data for galaxies as well to get more info. I will create it

@ritwik12
Copy link
Owner

ritwik12 commented Nov 4, 2019

@kousikr26 Please add test data.

@kousikr26
Copy link
Author

@ritwik12 added test data

@ritwik12
Copy link
Owner

ritwik12 commented Nov 5, 2019

@kousikr26 irregular_3.jpg seems doubtful to be real, better remove it. Two images are fine for test data. Also, where did you get the data. Google search or most websites will not be able to identify a spiral, elliptical or irregular galaxy and all pics will be mixed up which I can see in your data. Please manually verify all data is real and irregular galaxy only. Few are elliptical in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants