fix: "Exception thrown while executing UI block: -[rive_react_native.RiveReactNativeView setOnClick:]: unrecognized selector sent to instance" #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried the fix, and seems that it nessessary also the import |
|
Yes, seems reasonable. Thanks for pointing out and will check! |
|
Thanks, that's added now @lorenzoangelini |
|
Thanks! We'll merge this in for our next patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #214
When upgrading to React Native 0.73, it seems views receive experimental and unused props from React Native. By deriving the custom view
RiveReactNativeViewfromRCTViewfrom React Native instead ofUIView, stubs for these props are provided for free.I have checked this makes the specific issue I'm trying to fix go away and seems to run just fine, but please help me to understand if there may be unintended consequences or a better approach that might be more suitable.
Thanks in advance!