Skip to content

Commit

Permalink
Ensure child layouts mark dirty when flex direction changes
Browse files Browse the repository at this point in the history 
There is some odd behavior when changing flexDirection values (row/column/etc). For example, when "Fill" scale type is being used, child layouts can become completely collapsed when the parent's flexDirection changes.

The heart of the issue was that since we compute things like flexGrow/Shrink and align values in syncStyle based on the parent's flexDirection (before passing them into the layout engine), when a parent layout's flexDirection changes, we need to mark it's direct layout children dirty so syncStyle will be reapplied on them (which includes LayoutComponents and NestedArtboardLayouts).

https://github.com/user-attachments/assets/2bb130a8-ecf2-46cb-a810-87fe135bbc0a

Diffs=
1be9b574d1 Ensure child layouts mark dirty when flex direction changes (#8792)
  • Loading branch information
philter committed Dec 21, 2024
1 parent 07d25f4 commit 4119aee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4f4e07a68b9e9979532fcc932ced558f3f8e1047
1be9b574d145a1a1d7a32ed57416eb104af12986
2 changes: 1 addition & 1 deletion wasm/submodules/rive-runtime
Submodule rive-runtime updated 6 files
+1 −1 .rive_head
+1 −0 include/rive/layout_component.hpp
+1 −0 include/rive/nested_artboard_layout.hpp
+9 −4 src/layout/layout_component_style.cpp
+16 −0 src/layout_component.cpp
+6 −0 src/nested_artboard_layout.cpp

0 comments on commit 4119aee

Please sign in to comment.