-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release 0.21.0 #920
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces a new version entry for Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
e853e06
to
d939443
Compare
1774043
to
9b5297b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
4-5
: Remove unnecessary empty lines.There are two consecutive empty lines between the version header and the bug fixes section. One empty line is sufficient for readability.
## [0.20.2](https://github.com/rivenmedia/riven/compare/v0.20.1...v0.20.2) (2024-12-06) - - ### Bug Fixes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)pyproject.toml
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
3-14
: LGTM! Version entry follows semantic versioning and changelog conventions.
The changes are well-documented with:
- Appropriate version number for bug fixes (patch version)
- Clear descriptions of changes
- Proper linking to commits and issues
9b5297b
to
37ab8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)
6-8
: Consider adding more context about the symlinker retry change.While the feature is well documented with proper references, it would be helpful to include the rationale for adding a 6th retry attempt to the symlinker. This context would help users understand the impact and importance of this change.
11-19
: Consider improving consistency and clarity of bug fix entries.Some suggestions for improvement:
- Add issue references for entries that don't have them (lines 13-15)
- Make commit messages more descriptive:
- "api manual scraping fixes. wip" could be more specific about what was fixed
- "manual scraping updated for downloader rework" could explain the key changes
Consider applying this format to the entries:
-* api manual scraping fixes. wip ([7fb50f8](https://github.com/rivenmedia/riven/commit/7fb50f856d2395d2cbdc977a35e0a5ae152eecc0)) +* fix: improve API manual scraping by [specific changes] ([#issue](https://github.com/rivenmedia/riven/issues/issue)) ([7fb50f8](https://github.com/rivenmedia/riven/commit/7fb50f856d2395d2cbdc977a35e0a5ae152eecc0))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)pyproject.toml
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pyproject.toml
🔇 Additional comments (1)
CHANGELOG.md (1)
3-5
: LGTM! Version header follows the standard format.
The version header is properly formatted with the correct GitHub compare link and date.
37ab8b7
to
964a7f1
Compare
🤖 I have created a release beep boop
0.21.0 (2024-12-06)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
ListrrAPI
validate method for correct path usage.0.20.1
to0.21.0
in the project configuration.