Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to install the CLI in v0.11.3 #538

Closed
youssefsiam38 opened this issue Aug 20, 2024 · 3 comments · Fixed by #542
Closed

Unable to install the CLI in v0.11.3 #538

youssefsiam38 opened this issue Aug 20, 2024 · 3 comments · Fixed by #542

Comments

@youssefsiam38
Copy link

after running

go install github.com/riverqueue/river/cmd/river@latest

an error appeared

# github.com/riverqueue/river
../../../../go/pkg/mod/github.com/riverqueue/river@v0.11.3/client.go:481:27: undefined: baseservice.NewArchetype
../../../../go/pkg/mod/github.com/riverqueue/river@v0.11.3/client.go:659:30: c.baseStartStop.StoppedUnsafe undefined (type startstop.BaseStartStop has no field or method StoppedUnsafe)
../../../../go/pkg/mod/github.com/riverqueue/river@v0.11.3/client.go:720:23: undefined: startstop.StartAll

fixed when I downgraded to v0.11.2
@nexovec nexovec mentioned this issue Aug 20, 2024
Closed
@brandur
Copy link
Contributor

brandur commented Aug 20, 2024

Hmm, sorry for the trouble. I thought I'd tested this. Fix incoming.

brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Update indirect dependencies from update-mod-version script
8f5924f 
This is driven by [1] and the same bug we'd noticed in another project
previously too. Until now, `update-mod-version` hadn't been updating
versions on indirect dependencies, and `rivershared` in the CLI had been
indirect, thereby causing it to try and resolve v0.11.2 instead of
v0.11.3.

Here, update the script so that indirect dependencies are updated as
well.

[1] #538
@brandur brandur mentioned this issue Aug 20, 2024
Merged
brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Update indirect dependencies from update-mod-version script
d623f19 
This is driven by [1] and the same bug we'd noticed in another project
previously too. Until now, `update-mod-version` hadn't been updating
versions on indirect dependencies, and `rivershared` in the CLI had been
indirect, thereby causing it to try and resolve v0.11.2 instead of
v0.11.3.

Here, update the script so that indirect dependencies are updated as
well.

[1] #538
brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Bump rivershared to v0.11.3 in the CLI
144ef05 
Related to #538, bump `rivershared` to v0.11.3 in the CLI. Instead of
cutting a brand new release here, I think what we can probably do is
swap the CLI's release timestamp with a new one with the `rivershared`
dependency fixed.

There is a chance that that doesn't work because the Go sum database
will prevent a change in checksum. If that's the case, we'll have to
roll forward to v0.11.4 instead.
@brandur brandur mentioned this issue Aug 20, 2024
Merged
brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Update indirect dependencies from update-mod-version script (#540)
a43b18e 
This is driven by [1] and the same bug we'd noticed in another project
previously too. Until now, `update-mod-version` hadn't been updating
versions on indirect dependencies, and `rivershared` in the CLI had been
indirect, thereby causing it to try and resolve v0.11.2 instead of
v0.11.3.

Here, update the script so that indirect dependencies are updated as
well.

[1] #538
brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Bump rivershared to v0.11.3 in the CLI (#541)
c9b154f 
Related to #538, bump `rivershared` to v0.11.3 in the CLI. Instead of
cutting a brand new release here, I think what we can probably do is
swap the CLI's release timestamp with a new one with the `rivershared`
dependency fixed.

There is a chance that that doesn't work because the Go sum database
will prevent a change in checksum. If that's the case, we'll have to
roll forward to v0.11.4 instead.
brandur added a commit that referenced this issue Aug 20, 2024
@brandur
Prepare release v0.11.4
11f9bde 
Prepare release v0.11.4 to fix the bad release in v0.11.3 that was
causing the CLI to become uninstalled as described in #538. The release
script has now been updated in #534 so that the `rivershared` dependency
also gets properly bumped.

I'm also going to try to the `[skip ci]` tag during this release to
hopefully prevent bad caching in the Go proxy and make the release
available sooner.

Fixes #538.

[skip ci]
@brandur brandur mentioned this issue Aug 20, 2024
Merged
@nexovec
Copy link

nexovec commented Aug 20, 2024

@brandur You're a legend.

@brandur
Copy link
Contributor

brandur commented Aug 20, 2024

Hey, we recently cut v0.11.4, which fixes this issue.

The Go proxy caches for some amount of time. so if @latest is still resolving to v0.11.3, then you may need to grab v0.11.4 explicitly:

$ go install github.com/riverqueue/river/cmd/river@v0.11.4

If that is showing some 404s due to Go proxy caching, then you may need to use env vars to bypass it for now:

$ GOPROXY=direct GOSUMDB=off go install github.com/riverqueue/river/cmd/river@v0.11.4
go: downloading github.com/riverqueue/river v0.11.4
go: downloading github.com/riverqueue/river/riverdriver v0.11.4
go: downloading github.com/riverqueue/river/riverdriver/riverpgxv5 v0.11.4
go: downloading github.com/riverqueue/river/rivertype v0.11.4
go: downloading github.com/riverqueue/river/rivershared v0.11.4

(None of that should be necessary a half hour or so from now.)

@nexovec Hah, dunno about that, but thanks for the sentiment :)

tigrato pushed a commit to gravitational/river that referenced this issue Dec 18, 2024
@brandur @tigrato
Update indirect dependencies from update-mod-version script (riverq…
3311e0d 
…ueue#540)

This is driven by [1] and the same bug we'd noticed in another project
previously too. Until now, `update-mod-version` hadn't been updating
versions on indirect dependencies, and `rivershared` in the CLI had been
indirect, thereby causing it to try and resolve v0.11.2 instead of
v0.11.3.

Here, update the script so that indirect dependencies are updated as
well.

[1] riverqueue#538
tigrato pushed a commit to gravitational/river that referenced this issue Dec 18, 2024
@brandur @tigrato
Bump rivershared to v0.11.3 in the CLI (riverqueue#541)
67ecaaf 
Related to riverqueue#538, bump `rivershared` to v0.11.3 in the CLI. Instead of
cutting a brand new release here, I think what we can probably do is
swap the CLI's release timestamp with a new one with the `rivershared`
dependency fixed.

There is a chance that that doesn't work because the Go sum database
will prevent a change in checksum. If that's the case, we'll have to
roll forward to v0.11.4 instead.
tigrato pushed a commit to gravitational/river that referenced this issue Dec 18, 2024
@brandur @tigrato
Prepare release v0.11.4 (riverqueue#542)
a4dd032 
Prepare release v0.11.4 to fix the bad release in v0.11.3 that was
causing the CLI to become uninstalled as described in riverqueue#538. The release
script has now been updated in riverqueue#534 so that the `rivershared` dependency
also gets properly bumped.

I'm also going to try to the `[skip ci]` tag during this release to
hopefully prevent bad caching in the Go proxy and make the release
available sooner.

Fixes riverqueue#538.

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare release v0.11.4 riverqueue/river
3 participants
@brandur @nexovec @youssefsiam38