-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog to prepare for 0.0.4 release #32
Conversation
## [0.0.3] - 2023-11-13 | ||
|
||
### Changed | ||
|
||
- Fix license detection issues with riverdriver/riverpgxv5 submodule. | ||
- Ensure that river requires the riverpgxv5 module with the same version. | ||
- Fix license detection issues with `riverdriver/riverpgxv5` submodule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added backticks to these things.
Should we get in the habit of bumping the riverpgxv5 version here for each release? I think it affects which version gets pulled down on |
Sure. What's the order of operations there exactly? Do you have to bump it before you cut the release tag? (Presumably leaving the repo in a temporarily invalid state.) |
Yes, I think that’s correct. We should probably get in the habit of a “release prep” PR like this one which includes changelog entries and the version bump, then tag both modules immediately after merge. |
1c5c750
to
464fd5e
Compare
Alright, I'll give it a shot. Also added changelog entries for the minor docs change and reindexer disable. |
464fd5e
to
c3c3e59
Compare
Build passed even with the manually tweaked |
Yeah, builds within this module use the local |
Add the changes in #29 and #30 to the changelog so that we can cut a
0.0.4 release. For brevity and to keep signal high, I didn't include
changes that came in which aren't user facing.