Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog to prepare for 0.0.4 release #32

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Nov 17, 2023

Add the changes in #29 and #30 to the changelog so that we can cut a
0.0.4 release. For brevity and to keep signal high, I didn't include
changes that came in which aren't user facing.

## [0.0.3] - 2023-11-13

### Changed

- Fix license detection issues with riverdriver/riverpgxv5 submodule.
- Ensure that river requires the riverpgxv5 module with the same version.
- Fix license detection issues with `riverdriver/riverpgxv5` submodule.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added backticks to these things.

@brandur brandur requested a review from bgentry November 17, 2023 14:13
@bgentry
Copy link
Contributor

bgentry commented Nov 17, 2023

Should we get in the habit of bumping the riverpgxv5 version here for each release? I think it affects which version gets pulled down on go get github.com/riverqueue/river.

@brandur
Copy link
Contributor Author

brandur commented Nov 17, 2023

Should we get in the habit of bumping the riverpgxv5 version here for each release? I think it affects which version gets pulled down on go get github.com/riverqueue/river.

Sure. What's the order of operations there exactly? Do you have to bump it before you cut the release tag? (Presumably leaving the repo in a temporarily invalid state.)

@bgentry
Copy link
Contributor

bgentry commented Nov 17, 2023

Yes, I think that’s correct. We should probably get in the habit of a “release prep” PR like this one which includes changelog entries and the version bump, then tag both modules immediately after merge.

@brandur brandur force-pushed the brandur-changelog-update branch 2 times, most recently from 1c5c750 to 464fd5e Compare November 18, 2023 02:59
@brandur
Copy link
Contributor Author

brandur commented Nov 18, 2023

Yes, I think that’s correct. We should probably get in the habit of a “release prep” PR like this one which includes changelog entries and the version bump, then tag both modules immediately after merge.

Alright, I'll give it a shot.

Also added changelog entries for the minor docs change and reindexer disable.

Add the changes in #29 and #30 to the changelog so that we can cut a
0.0.4 release. For brevity and to keep signal high, I didn't include
changes that came in which aren't user facing.
@brandur brandur force-pushed the brandur-changelog-update branch from 464fd5e to c3c3e59 Compare November 18, 2023 03:01
@brandur
Copy link
Contributor Author

brandur commented Nov 18, 2023

Build passed even with the manually tweaked go.mod pointing to a non-existent version ... surprisingly.

@brandur brandur merged commit 37b4a72 into master Nov 18, 2023
5 checks passed
@brandur brandur deleted the brandur-changelog-update branch November 18, 2023 03:11
@bgentry
Copy link
Contributor

bgentry commented Nov 18, 2023

Build passed even with the manually tweaked go.mod pointing to a non-existent version ... surprisingly.

Yeah, builds within this module use the local replace directive in the go.mod, whereas that's ignored outside this module/repo. So you can point to an invalid version number in here and it just gets ignored because it's importing directly from the filesystem anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants