Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending job state to default unique job states #461

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Jul 19, 2024

Here, add the pending job state to the set of default unique states.
pending was a relatively recent addition in #301 and probably should
always have been in the default unique states, but pending isn't used yet
so no one noticed one way or the other.

bgentry and others added 2 commits July 18, 2024 18:25
This still needs tests and documentation.
Here, add the `pending` job state to the set of default unique states.
`pending` was a relatively recent addition in #301 and probably should
always have been in the default unique states, but `pending` isn't used
yet so no one noticed one way or the other.
@brandur
Copy link
Contributor Author

brandur commented Jul 19, 2024

@bgentry There's a test case in dbunique that iterates through the default unique states and makes sure they're included to return the same job. I added pending to that and I think that's sufficient test coverage for this.

@brandur brandur requested a review from bgentry July 19, 2024 04:45
@brandur
Copy link
Contributor Author

brandur commented Jul 19, 2024

Thanks!

@brandur brandur merged commit 0ba7ed4 into master Jul 19, 2024
10 checks passed
@brandur brandur deleted the brandur-pending branch July 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants