database/sql: default to current time if scheduled_at unspecified #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg-test-for-insert-many-tx-scheduled-at-default-value
branch
from
9911e85 to
efeeebc
Compare
bgentry
force-pushed
the
bg-test-for-insert-many-tx-scheduled-at-default-value
branch
from
efeeebc to
aaf8a18
Compare
The database/sql driver had a slightly different behavior than the pgx driver in that it was setting the `scheduled_at` time to `null`, rather than setting the current timestamp if one was not specified. Additionally, the driver test suite did not cover this case at all. Fix both of these issues. Fixes #502.
bgentry
force-pushed
the
bg-test-for-insert-many-tx-scheduled-at-default-value
branch
from
aaf8a18 to
2d410d4
Compare
brandur
approved these changes
Aug 6, 2024
bgentry
deleted the
bg-test-for-insert-many-tx-scheduled-at-default-value
branch
Merged
brandur
added a commit
that referenced
this pull request
Aug 6, 2024
Merged
brandur
added a commit
that referenced
this pull request
Aug 9, 2024
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
Prepare release v0.11.2, containing riverqueue#504 and riverqueue#505. This will also require a separate CLI release because of some minimum Go version changes in all the project's `go.mod` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database/sql driver had a slightly different behavior than the pgx driver in that it was setting the
scheduled_attime tonull, rather than setting the current timestamp if one was not specified.Additionally, the driver test suite did not cover this case at all.
Fix both of these issues. Fixes #502.