Improve error when Client.Subscribe called on a client that will not work
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Sep 18, 2024
…t work Related to #596. If `Subscribe` was called on a client that didn't have a `Workers` bundle configure a nil pointer panic would occur because `subscriptionManager` was never initialized. Here, leave that as a panic since it makes sense to warn a user about an API misuse that'd undoubtedly lead to more confusion/pain, but improve the error message so that it's more obvious to the caller why this is a problem. Fixes #596.
brandur
force-pushed
the
brandur-subscribe-panic
branch
from
898bfa5 to
b1e240c
Compare
|
ty. |
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
…t work (riverqueue#599) Related to riverqueue#596. If `Subscribe` was called on a client that didn't have a `Workers` bundle configure a nil pointer panic would occur because `subscriptionManager` was never initialized. Here, leave that as a panic since it makes sense to warn a user about an API misuse that'd undoubtedly lead to more confusion/pain, but improve the error message so that it's more obvious to the caller why this is a problem. Fixes riverqueue#596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #596. If
Subscribewas called on a client that didn't havea
Workersbundle configure a nil pointer panic would occur becausesubscriptionManagerwas never initialized.Here, leave that as a panic since it makes sense to warn a user about an
API misuse that'd undoubtedly lead to more confusion/pain, but improve
the error message so that it's more obvious to the caller why this is a
problem.
Fixes #596.