Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run make tidy #613

Merged
merged 1 commit into from
Sep 24, 2024
Merged

run make tidy #613

merged 1 commit into from
Sep 24, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Sep 23, 2024

I'm not sure if there's something missing in the release instructions, but it doesn't seem like anything other than cmd/river ever gets go mod tidy run on it.

@bgentry bgentry requested a review from brandur September 23, 2024 19:58
@@ -7,6 +7,7 @@ toolchain go1.23.0
require (
github.com/jackc/pgx/v5 v5.7.1
github.com/lib/pq v1.10.9
github.com/riverqueue/river v0.12.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandur hmm, I think I've created a cycle here? Both drivers are now calling dbunique.UniqueBitmaskToStates() in internal/dbunique, which has made them both take a dependency on the main river package. And the main package depends on the drivers too due to testing:

river/go.mod

Lines 12 to 13 in 5e35335

github.com/riverqueue/river/riverdriver/riverdatabasesql v0.12.0
github.com/riverqueue/river/riverdriver/riverpgxv5 v0.12.0

@bgentry
Copy link
Contributor Author

bgentry commented Sep 24, 2024

Still not quite sure if this is missing from one of the release steps (it's only listed under CLI release) but it seems necessary to get it merged so I'm doing that now. Lmk your thoughts ✌️

@bgentry bgentry merged commit e9b751f into master Sep 24, 2024
14 checks passed
@bgentry bgentry deleted the bg-mod-tidy branch September 24, 2024 21:02
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant