Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose JobCancelError, JobSnoozeError #665

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Nov 3, 2024

These were initially kept as unexported types, but it turns out they're useful for testing. Still, they should not be initialized directly (i.e. from within workers) and should be used through the JobCancel and JobSnooze top level functions.

Fixes #625.

@bgentry bgentry requested a review from brandur November 3, 2024 19:37
These were initially kept as unexported types, but it turns out they're
useful for testing. Still, they should not be initialized directly (i.e.
from within workers) and should be used through the `JobCancel` and
`JobSnooze` top level functions.

Fixes #625.
@bgentry bgentry force-pushed the bg-expose-error-types branch from 6348bd7 to 14ca3eb Compare November 3, 2024 19:38
@bgentry bgentry merged commit 30f09a0 into master Nov 3, 2024
14 checks passed
@bgentry bgentry deleted the bg-expose-error-types branch November 3, 2024 19:43
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
These were initially kept as unexported types, but it turns out they're
useful for testing. Still, they should not be initialized directly (i.e.
from within workers) and should be used through the `JobCancel` and
`JobSnooze` top level functions.

Fixes riverqueue#625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make jobCancelError and jobSnoozeError public
1 participant