Consistently prefer job param name to j
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Nov 26, 2023
When using a job parameter name for a worker, we weren't consistent
about whether to use `j` or `job` and have mixed convention all over the
place:
func (w *Worker) Work(ctx context.Context, j *river.Job[ErroringArgs]) error {
func (w *Worker) Work(ctx context.Context, job *river.Job[ErroringArgs]) error {
Generally in non-core-team Go, a convention of more than single
character variable names is preferred except in specific cases (e.g.
`i`), so here, move everything over to use the more explicit `job`.
bgentry
force-pushed
the
brandur-job-param-name
branch
from
64f3d36 to
b511803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a job parameter name for a worker, we weren't consistent
about whether to use
jorjoband have mixed convention all over theplace:
Generally in non-core-team Go, a convention of more than single
character variable names is preferred except in specific cases (e.g.
i), so here, move everything over to use the more explicitjob.