-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate existing unique_states
column in 006 migration
#690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-tolerate-existing-column
branch
from
December 12, 2024 03:44
dc6f393
to
e798c27
Compare
bgentry
approved these changes
Dec 12, 2024
As described in #688, if a user has followed changelog instructions to create the new index concurrently, they will encounter an error as they try to run the 006 migration to finalize it. Here, tolerate the column already existing to fix the problem. An existing index is already tolerated. Fixes #688.
brandur
force-pushed
the
brandur-tolerate-existing-column
branch
from
December 14, 2024 21:07
e798c27
to
ca4f13c
Compare
Thx. Added changelog. |
Merged
brandur
added a commit
that referenced
this pull request
Dec 15, 2024
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
…#690) As described in riverqueue#688, if a user has followed changelog instructions to create the new index concurrently, they will encounter an error as they try to run the 006 migration to finalize it. Here, tolerate the column already existing to fix the problem. An existing index is already tolerated. Fixes riverqueue#688.
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
Just an incremental release with a couple small changes in riverqueue#690 and riverqueue#691. [skip ci]
brandur
added a commit
that referenced
this pull request
Dec 19, 2024
Inverts links on #690 and #691 which currently point to each others pull requests instead of their own, as reported in [1]. [1] #688 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #688, if a user has followed changelog instructions to
create the new index concurrently, they will encounter an error as they
try to run the 006 migration to finalize it.
Here, tolerate the column already existing to fix the problem. An
existing index is already tolerated.
Fixes #688.