Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate existing unique_states column in 006 migration #690

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Dec 12, 2024

As described in #688, if a user has followed changelog instructions to
create the new index concurrently, they will encounter an error as they
try to run the 006 migration to finalize it.

Here, tolerate the column already existing to fix the problem. An
existing index is already tolerated.

Fixes #688.

@brandur brandur force-pushed the brandur-tolerate-existing-column branch from dc6f393 to e798c27 Compare December 12, 2024 03:44
@brandur brandur requested a review from bgentry December 12, 2024 04:00
As described in #688, if a user has followed changelog instructions to
create the new index concurrently, they will encounter an error as they
try to run the 006 migration to finalize it.

Here, tolerate the column already existing to fix the problem. An
existing index is already tolerated.

Fixes #688.
@brandur brandur force-pushed the brandur-tolerate-existing-column branch from e798c27 to ca4f13c Compare December 14, 2024 21:07
@brandur
Copy link
Contributor Author

brandur commented Dec 14, 2024

Thx. Added changelog.

@brandur brandur merged commit ce154bb into master Dec 14, 2024
10 checks passed
@brandur brandur deleted the brandur-tolerate-existing-column branch December 14, 2024 21:25
brandur added a commit that referenced this pull request Dec 14, 2024
Just an incremental release with a couple small changes in #690 and #691.
brandur added a commit that referenced this pull request Dec 14, 2024
Just an incremental release with a couple small changes in #690 and #691.

[skip ci]
@brandur brandur mentioned this pull request Dec 14, 2024
brandur added a commit that referenced this pull request Dec 15, 2024
Just an incremental release with a couple small changes in #690 and #691.

[skip ci]
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
…#690)

As described in riverqueue#688, if a user has followed changelog instructions to
create the new index concurrently, they will encounter an error as they
try to run the 006 migration to finalize it.

Here, tolerate the column already existing to fix the problem. An
existing index is already tolerated.

Fixes riverqueue#688.
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
Just an incremental release with a couple small changes in riverqueue#690 and riverqueue#691.

[skip ci]
brandur added a commit that referenced this pull request Dec 19, 2024
Inverts links on #690 and #691 which currently point to each others pull
requests instead of their own, as reported in [1].

[1] #688 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with migrations for 0.12.0
2 participants