calculate retries based off current time, not job start time #74
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a demo app, I was seeing a bunch of errors with this message:
> Retry policy returned invalid next retry before current time; using
> default retry policy instead
The only problem is, I _was_ using the default retry policy for this
worker and client. These log lines manifested because the
`DefaultClientRetryPolicy` is calculating the next attempt based on:
job.AttemptedAt + backoffDuration
This isn't really noticeable if the job is super quick, but if like my
demo app your job is taking 10s of seconds or longer, the next attempt
could actually be scheduled for far in the past instead of in the
future, making it run again immediately instead of after the backoff
duration.
This commit changes the behavior to only look at the current time
(`time.Now().UTC()`) when determining when the next attempt should be,
without regard to when the last attempt began.
brandur
approved these changes
Nov 26, 2023
bgentry
added a commit
that referenced
this pull request
Nov 27, 2023
This was changed in #74, but the changelog entry was added to an existing version instead of the new/unreleased one.
bgentry
added a commit
that referenced
this pull request
Nov 27, 2023
This was changed in #74, but the changelog entry was added to an existing version instead of the new/unreleased one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a demo app, I was seeing a bunch of errors with this message:
The only problem is, I was using the default retry policy for this worker and client. These log lines manifested because the
DefaultClientRetryPolicyis calculating the next attempt based on:This isn't really noticeable if the job is super quick, but if like my demo app your job is taking 10s of seconds or longer, the next attempt could actually be scheduled for far in the past instead of in the future, making it run again immediately instead of after the backoff duration.
This commit changes the behavior to only look at the current time (
time.Now().UTC()) when determining when the next attempt should be, without regard to when the last attempt began.