Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused queries variable in job enqueuer #89

Merged
merged 1 commit into from
Dec 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused queries variable in job enqueuer
A trivial change, but I noticed the other day that the `queries`
property on the periodic job enqueuer is unused. It was originally, but
it's usefulness was eventually refactored out of existence. Here, remove
the extraenous code.
brandur committed Dec 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d38d272655436e177bb130b0f2fa2602f6ae8606
3 changes: 0 additions & 3 deletions internal/maintenance/periodic_job_enqueuer.go
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@ import (

"github.com/riverqueue/river/internal/baseservice"
"github.com/riverqueue/river/internal/dbadapter"
"github.com/riverqueue/river/internal/dbsqlc"
"github.com/riverqueue/river/internal/maintenance/startstop"
"github.com/riverqueue/river/internal/rivercommon"
)
@@ -72,7 +71,6 @@ type PeriodicJobEnqueuer struct {

dbAdapter dbadapter.Adapter
periodicJobs []*PeriodicJob
queries *dbsqlc.Queries
}

func NewPeriodicJobEnqueuer(archetype *baseservice.Archetype, config *PeriodicJobEnqueuerConfig, dbAdapter dbadapter.Adapter) *PeriodicJobEnqueuer {
@@ -83,7 +81,6 @@ func NewPeriodicJobEnqueuer(archetype *baseservice.Archetype, config *PeriodicJo

dbAdapter: dbAdapter,
periodicJobs: config.PeriodicJobs,
queries: dbsqlc.New(),
})

return svc