chore: make actor create runtime optional & fix inconsistent snake ca…

…se in api (#1494)  ## Changes
rivet-gg · Dec 1, 2024 · f260ab5 · f260ab5
1 parent b63ae81
commit f260ab5
Show file tree

Hide file tree

Showing 26 changed files with 54 additions and 67 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/packages/api/actor/src/route/actors.rs b/packages/api/actor/src/route/actors.rs
@@ -158,7 +158,7 @@ pub async fn create(
 		// args: body.runtime.arguments.unwrap_or_default(),
 		args: Vec::new(),
 		network_mode: network.mode.unwrap_or_default().api_into(),
-		environment: body.runtime.environment.unwrap_or_default(),
+		environment: body.runtime.and_then(|r| r.environment).unwrap_or_default(),
 		network_ports: unwrap!(network
 			.ports
 			.unwrap_or_default()
@@ -331,9 +331,9 @@ pub async fn create_deprecated(
 				cpu: body.resources.cpu,
 				memory: body.resources.memory,
 			}),
-			runtime: Box::new(models::ActorCreateActorRuntimeRequest {
+			runtime: Some(Box::new(models::ActorCreateActorRuntimeRequest {
 				environment: body.runtime.environment,
-			}),
+			})),
 			build: Some(body.runtime.build),
 			build_tags: None,
 			tags: body.tags,

diff --git a/packages/services/build/ops/create/src/lib.rs b/packages/services/build/ops/create/src/lib.rs
@@ -27,8 +27,7 @@ async fn handle(
 		.await?;
 		let game = game_res.games.first();
 		ensure!(game.is_some(), "game not found");
-	}
-	else if let Some(env_id) = env_id {
+	} else if let Some(env_id) = env_id {
 		let env_res = op!([ctx] game_namespace_get {
 			namespace_ids: vec![env_id.into()],
 		})

diff --git a/sdks/api/fern/definition/actor/__package__.yml b/sdks/api/fern/definition/actor/__package__.yml
@@ -111,8 +111,8 @@ types:
       region: optional<string>
       tags: unknown
       build: optional<uuid>
-      buildTags: optional<unknown>
-      runtime: CreateActorRuntimeRequest
+      build_tags: optional<unknown>
+      runtime: optional<CreateActorRuntimeRequest>
       network: optional<CreateActorNetworkRequest>
       resources: commons.Resources
       lifecycle: optional<commons.Lifecycle>
@@ -145,7 +145,7 @@ types:
   UpgradeActorRequest:
     properties:
       build: optional<uuid>
-      buildTags: optional<unknown>
+      build_tags: optional<unknown>
 
   UpgradeActorResponse:
     properties: {}
@@ -154,7 +154,7 @@ types:
     properties:
       tags: unknown
       build: optional<uuid>
-      buildTags: optional<unknown>
+      build_tags: optional<unknown>
 
   UpgradeAllActorsResponse:
     properties:

diff --git a/sdks/api/full/go/actor/actor.go b/sdks/api/full/go/actor/actor.go
diff --git a/sdks/api/full/openapi/openapi.yml b/sdks/api/full/openapi/openapi.yml
diff --git a/sdks/api/full/openapi_compat/openapi.yml b/sdks/api/full/openapi_compat/openapi.yml
diff --git a/sdks/api/full/rust-cli/docs/ActorCreateActorRequest.md b/sdks/api/full/rust-cli/docs/ActorCreateActorRequest.md
diff --git a/sdks/api/full/rust-cli/src/models/actor_create_actor_request.rs b/sdks/api/full/rust-cli/src/models/actor_create_actor_request.rs
diff --git a/sdks/api/full/rust-cli/src/models/actor_upgrade_actor_request.rs b/sdks/api/full/rust-cli/src/models/actor_upgrade_actor_request.rs
diff --git a/sdks/api/full/rust-cli/src/models/actor_upgrade_all_actors_request.rs b/sdks/api/full/rust-cli/src/models/actor_upgrade_all_actors_request.rs
diff --git a/sdks/api/full/rust/docs/ActorCreateActorRequest.md b/sdks/api/full/rust/docs/ActorCreateActorRequest.md
diff --git a/sdks/api/full/rust/src/models/actor_create_actor_request.rs b/sdks/api/full/rust/src/models/actor_create_actor_request.rs
diff --git a/sdks/api/full/rust/src/models/actor_upgrade_actor_request.rs b/sdks/api/full/rust/src/models/actor_upgrade_actor_request.rs
diff --git a/sdks/api/full/rust/src/models/actor_upgrade_all_actors_request.rs b/sdks/api/full/rust/src/models/actor_upgrade_all_actors_request.rs
diff --git a/sdks/api/full/typescript/src/api/resources/actor/client/Client.ts b/sdks/api/full/typescript/src/api/resources/actor/client/Client.ts
diff --git a/sdks/api/full/typescript/src/api/resources/actor/client/requests/CreateActorRequestQuery.ts b/sdks/api/full/typescript/src/api/resources/actor/client/requests/CreateActorRequestQuery.ts
diff --git a/sdks/api/runtime/go/actor/actor.go b/sdks/api/runtime/go/actor/actor.go
diff --git a/sdks/api/runtime/openapi/openapi.yml b/sdks/api/runtime/openapi/openapi.yml