Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pb manager debug metrics, handle unknown isolate runner gracefully #1711

Closed
wants to merge 1 commit into from
Closed

fix: add pb manager debug metrics, handle unknown isolate runner gracefully #1711

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Dec 26, 2024 •
edited
Loading

Fixes RVT-4456
Fixes RVT-4464
Fixes RVT-4501

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 26, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c42e1cc
Status: ✅  Deploy successful!
Preview URL: https://793808aa.rivet.pages.dev
Branch Preview URL: https://12-26-fix-add-pb-manager-deb.rivet.pages.dev

View logs

This was referenced Dec 26, 2024
Closed
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Dec 27, 2024 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Dec 27, 2024
Closed
@linear Linear
Copy link

linear bot commented Dec 27, 2024

RVT-4456 Dead pegboard client, in reconnect loop

RVT-4501 Create metric + alert for SQL errors from PB manager

RVT-4464 Pegboard manager `UNIQUE constraint failed: commands.idx`

This was referenced Dec 27, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
NathanFlurry
NathanFlurry requested changes Dec 31, 2024
View reviewed changes
packages/infra/client/manager/src/ctx.rs Outdated Show resolved Hide resolved
packages/infra/client/manager/src/runner.rs Outdated Show resolved Hide resolved
packages/infra/client/manager/src/utils/sql.rs Show resolved Hide resolved
@linear Linear
Copy link

linear bot commented Dec 31, 2024

RVT-4501 Create metric + alert for SQL errors from PB manager

@MasterPtato MasterPtato force-pushed the 12-26-fix_add_unique_wf_dispatch branch from 1c4381c to 3415e28 Compare December 31, 2024 19:29
@MasterPtato MasterPtato force-pushed the 12-26-fix_add_pb_manager_debug_metrics_handle_unknown_isolate_runner_gracefully branch from 7e83247 to 10be155 Compare December 31, 2024 19:29
@MasterPtato MasterPtato mentioned this pull request Dec 31, 2024
Closed
@MasterPtato MasterPtato force-pushed the 12-26-fix_add_pb_manager_debug_metrics_handle_unknown_isolate_runner_gracefully branch from 10be155 to c42e1cc Compare December 31, 2024 22:12
@MasterPtato MasterPtato mentioned this pull request Dec 31, 2024
Closed
@MasterPtato MasterPtato mentioned this pull request Jan 1, 2025
Closed
This was referenced Jan 2, 2025
Closed
Closed
Closed
@MasterPtato MasterPtato mentioned this pull request Jan 2, 2025
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jan 2, 2025 •
edited
Loading

Merge activity

  • Jan 2, 3:31 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 2, 3:32 PM EST: CI is running for this PR on a draft PR: #1759
  • Jan 2, 3:37 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1759.

@NathanFlurry NathanFlurry mentioned this pull request Jan 2, 2025
Closed
MasterPtato added a commit that referenced this pull request Jan 2, 2025
@MasterPtato
fix: add pb manager debug metrics, handle unknown isolate runner grac…
f1634fe 
…efully (#1711)

<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4456
Fixes RVT-4464
Fixes RVT-4501
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jan 2, 2025
@graphite-app graphite-app bot deleted the 12-26-fix_add_pb_manager_debug_metrics_handle_unknown_isolate_runner_gracefully branch January 2, 2025 20:37
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Merged
This was referenced Jan 2, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 18, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry