Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix toolchain tags patch hack #1754

Closed
wants to merge 1 commit into from
Closed

fix: fix toolchain tags patch hack #1754

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Dec 31, 2024 •
edited
Loading

Fixes RVT-4261

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 31, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c280104
Status: ✅  Deploy successful!
Preview URL: https://964881c7.rivet.pages.dev
Branch Preview URL: https://12-31-fix-fix-toolchain-tags.rivet.pages.dev

View logs

This was referenced Dec 31, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Dec 31, 2024 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato force-pushed the 12-31-fix_fix_toolchain_tags_patch_hack branch from 0e20d8f to 7219574 Compare December 31, 2024 23:51
@MasterPtato MasterPtato marked this pull request as ready for review December 31, 2024 23:51
@linear Linear
Copy link

linear bot commented Dec 31, 2024

RVT-4261 Revert & validate build tag patching hack fix

@MasterPtato MasterPtato force-pushed the 12-31-fix_fix_toolchain_tags_patch_hack branch from 7219574 to c280104 Compare December 31, 2024 23:55
@MasterPtato MasterPtato mentioned this pull request Jan 1, 2025
Closed
This was referenced Jan 2, 2025
Closed
Closed
Closed
@MasterPtato MasterPtato mentioned this pull request Jan 2, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Jan 2, 2025
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jan 2, 2025 •
edited
Loading

Merge activity

  • Jan 2, 3:36 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 2, 3:37 PM EST: CI is running for this PR on a draft PR: #1761
  • Jan 2, 3:42 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1761.

MasterPtato added a commit that referenced this pull request Jan 2, 2025
@MasterPtato
fix: fix toolchain tags patch hack (#1754)
e003143 
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4261
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@MasterPtato MasterPtato changed the base branch from 12-31-chore_add_infra_client_to_main_workspace to graphite-base/1754 January 2, 2025 20:40
@graphite-app graphite-app bot closed this Jan 2, 2025
@graphite-app graphite-app bot deleted the 12-31-fix_fix_toolchain_tags_patch_hack branch January 2, 2025 20:42
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Merged
This was referenced Jan 2, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 18, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry