-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve default export error message #1895
Closed
NathanFlurry
wants to merge
1
commit into
12-27-chore_examples_add_registry
from
fix_improve_default_export_error_message
Closed
fix: improve default export error message #1895
NathanFlurry
wants to merge
1
commit into
12-27-chore_examples_add_registry
from
fix_improve_default_export_error_message
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Improved error message clarity for default exports in JavaScript by removing incorrect double curly braces from example code in error messages.
- Modified
packages/infra/client/isolate-v8-runner/src/isolate.rs
to fix syntax in error message example, making it more accurate for developers
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
12-27-chore_examples_add_registry
branch
from
January 22, 2025 04:58
4582ea2
to
42f8486
Compare
NathanFlurry
force-pushed
the
fix_improve_default_export_error_message
branch
from
January 22, 2025 04:58
bb0ceab
to
e42a105
Compare
NathanFlurry
force-pushed
the
12-27-chore_examples_add_registry
branch
from
January 22, 2025 08:08
42f8486
to
21d46fc
Compare
NathanFlurry
force-pushed
the
fix_improve_default_export_error_message
branch
from
January 22, 2025 08:09
e42a105
to
3ce31c2
Compare
NathanFlurry
force-pushed
the
12-27-chore_examples_add_registry
branch
from
January 22, 2025 08:37
21d46fc
to
4012286
Compare
NathanFlurry
force-pushed
the
fix_improve_default_export_error_message
branch
from
January 22, 2025 08:37
3ce31c2
to
02e841a
Compare
This was referenced Jan 22, 2025
Merge activity
|
Closed
NathanFlurry
force-pushed
the
12-27-chore_examples_add_registry
branch
from
January 22, 2025 16:19
4012286
to
cd4d235
Compare
NathanFlurry
force-pushed
the
fix_improve_default_export_error_message
branch
from
January 22, 2025 16:19
02e841a
to
b318933
Compare
NathanFlurry
added a commit
that referenced
this pull request
Jan 22, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes