chore(sdks/actor): remove all jsr libraries #1915

NathanFlurry · 2025-01-22T14:55:12Z

Changes

cloudflare-workers-and-pages · 2025-01-22T14:55:39Z

Deploying rivet with Cloudflare Pages

Latest commit:	`5350091`
Status:	🚫 Build failed.

View logs

NathanFlurry · 2025-01-22T14:55:41Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-01-22T14:55:45Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`ddb42ad`
Status:	⚡️ Build in progress...

View logs

greptile-apps

PR Summary

This PR focuses on removing JSR libraries and updating dependencies for NPM compatibility across the actor SDK.

Changed platform from 'neutral' to 'node' in sdks/actor/runtime/tsup.config.ts, impacting build output compatibility
Replaced @std/cbor with cbor-x in sdks/actor/client/src/handle.ts and related files for CBOR encoding/decoding
Implemented custom Logger class in sdks/actor/common/src/log.ts to replace @std/log functionality
Added new Lock and deadline utilities in sdks/actor/runtime/src/utils.ts to replace @core/asyncutil functionality
Significant version downgrade from 24.6.2-rc.1 to 0.0.3 in package.json files, potentially impacting dependent packages

_{20 file(s) reviewed, 8 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-01-22T14:56:55Z

sdks/actor/client/src/test.ts

-import type { ClientOptions } from "./client.ts";
-import { InternalError } from "./errors.ts";
+import type { ClientOptions } from "./client";
+import { InternalError } from "./errors";
 import { Client } from "./mod.ts";


style: inconsistent extension usage - mod.ts still has .ts extension while other local imports had it removed

greptile-apps · 2025-01-22T14:57:06Z

sdks/actor/common/src/log.ts

+interface LogRecord {
+	args: unknown[];
+	datetime: Date;
+	level: number;
+	levelName: string;
+	loggerName: string;
+	msg: string;
 }


style: LogRecord interface includes levelName which is redundant since level is already stored and can be mapped using LevelNameMap

greptile-apps · 2025-01-22T14:57:41Z

sdks/actor/manager/src/mod.ts

+			if (!httpPort) throw new Error("missing http port");
 			const hostname = httpPort.hostname;
-			assertExists(hostname);
+			if (!hostname) throw new Error("missing hostname");
 			const port = httpPort.port;
-			assertExists(port);
+			if (!port) throw new Error("missing port");


style: Consider consolidating these three checks into a single error message since they're all related to port configuration

greptile-apps · 2025-01-22T14:57:53Z

sdks/actor/manager/src/query_exec.ts

+		if ((a.tags as ActorTags).access !== "public") {
+			throw new Error("unreachable: actor tags not public");
+		}


logic: The error message mentions this is 'unreachable', but the code path is clearly reachable since we're checking for it. Consider renaming the error message to better reflect that this is an invalid state rather than an unreachable one.

greptile-apps · 2025-01-22T14:58:34Z

sdks/actor/runtime/src/connection.ts

@@ -52,7 +51,7 @@ export class Connection<A extends AnyActor> {
 	 */
 	public get state(): ExtractActorConnState<A> {
 		this.#validateStateEnabled();
-		assertExists(this.#state, "state should exist");
+		if (!this.#state) throw new Error("state should exists");


syntax: typo in error message: 'exists' should be 'exist'

greptile-apps · 2025-01-22T14:58:55Z

sdks/actor/runtime/src/utils.ts

@@ -32,3 +32,44 @@ export const throttle = <
 		} else lastArgs = args;
 	};
 };
+
+export function deadline<T>(promise: Promise<T>, timeout: number): Promise<T> {


style: timeout parameter should be validated to ensure it's a positive number

greptile-apps · 2025-01-22T14:59:02Z

sdks/actor/runtime/tsconfig.json

 		"esModuleInterop": false,
-		"allowSyntheticDefaultImports": false,
+		"allowSyntheticDefaultImports": true,


logic: Having esModuleInterop: false but allowSyntheticDefaultImports: true is an unusual combination that may cause issues. These settings typically work together - consider enabling both or disabling both.

greptile-apps · 2025-01-22T14:59:02Z

sdks/actor/runtime/tsconfig.json

 		"moduleResolution": "bundler",
-		"types": ["deno"],
+		"types": ["node", "deno"],


style: Using moduleResolution 'bundler' with both Node and Deno types may cause resolution conflicts. Consider using 'node' or 'nodenext' for better NPM compatibility.

graphite-app · 2025-01-22T15:10:32Z

Merge activity

Jan 22, 10:10 AM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 10:12 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 10:13 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 10:30 AM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 10:33 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 10:33 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 10:43 AM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 10:45 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 10:45 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #1880.
Jan 22, 11:20 AM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 11:23 AM EST: CI is running for this PR on a draft PR: #1930
Jan 22, 11:24 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1930.

## Changes

This was referenced Jan 22, 2025

fix(sdks/actor/client): enable @rivet-gg/actor-client/test to run in node env #1912

Closed

feat(cli): automatically prompt to login for commands that require auth #1913

Closed

This was referenced Jan 22, 2025

chore(toolchain): update default templates for npm compat #1914

Closed

chore: remove jsr packages from js-utils-embed #1916

Closed

NathanFlurry mentioned this pull request Jan 22, 2025

fix(cli): make esbuild portable #1917

Closed

greptile-apps bot reviewed Jan 22, 2025

View reviewed changes

This was referenced Jan 22, 2025

chore: upgrade system-test to npm #1918

Closed

chore: add deno.json warning in deploy task #1919

Closed

NathanFlurry mentioned this pull request Jan 22, 2025

chore: update apis #1922

Closed

NathanFlurry and others added 2 commits January 22, 2025 08:18

chore(sdks/actor): remove all jsr libraries

c1ac406

[autofix.ci] apply automated fixes

ddb42ad

NathanFlurry force-pushed the 01-22-chore_toolchain_update_default_templates_for_npm_compat branch from afef200 to dd4c4bb Compare January 22, 2025 16:19

NathanFlurry force-pushed the 01-22-chore_sdks_actor_remove_all_jsr_libraries branch from 5350091 to ddb42ad Compare January 22, 2025 16:20

NathanFlurry added a commit that referenced this pull request Jan 22, 2025

chore(sdks/actor): remove all jsr libraries (#1915)

fcceb8d

 ## Changes

graphite-app bot closed this Jan 22, 2025

graphite-app bot deleted the 01-22-chore_sdks_actor_remove_all_jsr_libraries branch January 22, 2025 16:24

github-actions bot mentioned this pull request Jan 22, 2025

chore(main): release 25.1.0 #1839

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(sdks/actor): remove all jsr libraries #1915

chore(sdks/actor): remove all jsr libraries #1915

NathanFlurry commented Jan 22, 2025

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

NathanFlurry commented Jan 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

greptile-apps bot Jan 22, 2025

graphite-app bot commented Jan 22, 2025 •

edited

Loading

chore(sdks/actor): remove all jsr libraries #1915

chore(sdks/actor): remove all jsr libraries #1915

Conversation

NathanFlurry commented Jan 22, 2025

Changes

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

NathanFlurry commented Jan 22, 2025 • edited Loading

How to use the Graphite Merge Queue

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading

Deploying rivet-hub with Cloudflare Pages

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

greptile-apps bot Jan 22, 2025

Choose a reason for hiding this comment

graphite-app bot commented Jan 22, 2025 • edited Loading

Merge activity

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

NathanFlurry commented Jan 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

graphite-app bot commented Jan 22, 2025 •

edited

Loading