Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename ports vars to uppercase #1485

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/infra/client/manager/src/actor/setup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ impl Actor {
// Add port env vars and api endpoint
.chain(ports.iter().map(|(label, port)| {
(
format!("PORT_{}", label.replace('-', "_")),
format!("PORT_{}", label.to_uppercase().replace('-', "_")),
port.target.to_string(),
)
}))
Expand Down
2 changes: 1 addition & 1 deletion packages/infra/client/manager/tests/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ console.log(Rivet.metadata);

let server = Deno.serve({
handler,
port: parseInt(Deno.env.get("PORT_main")),
port: parseInt(Deno.env.get("PORT_MAIN")),
});

await server.finished;
Expand Down
2 changes: 1 addition & 1 deletion resources/default-builds/js/test-js-echo/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ console.log(Deno.env.toObject());

let server = Deno.serve({
handler,
port: parseInt(Deno.env.get("PORT_ds_testing2") ?? Deno.env.get("HTTP_PORT")),
port: parseInt(Deno.env.get("PORT_DS_TESTING2") ?? Deno.env.get("HTTP_PORT")),
});

await server.finished;
Expand Down
2 changes: 1 addition & 1 deletion scripts/manual_tests/fixtures/echo_http.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ console.log(Deno.env.toObject());

let server = Deno.serve({
handler,
port: parseInt(Deno.env.get("PORT_ds_http") ?? Deno.env.get("HTTP_PORT")),
port: parseInt(Deno.env.get("PORT_DS_HTTP") ?? Deno.env.get("HTTP_PORT")),
hostname: "0.0.0.0",
});

Expand Down
Loading