feat(workflows): add loop state #1939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
35b98b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0240445.rivet.pages.dev |
| Branch Preview URL: | https://01-24-feat-workflows-add-loo.rivet.pages.dev |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds loop state functionality to the workflow system, enabling state persistence between loop iterations in workflow executions.
- Added new
stateJSONB column toworkflow_loop_eventstable with migration20250124210139_add_loop_state.up.sql - Added
loopemethod toWorkflowCtxfor handling stateful loops with type-safe state management - Added
SerializeLoopState/DeserializeLoopStateerror variants to handle state serialization - Missing down migration for removing the
statecolumn could cause issues with schema rollbacks - Commented out
outputfield inSubWorkflowEventmay impact workflow monitoring capabilities
💡 (5/5) You can turn off certain types of comments like style here!
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
MasterPtato
force-pushed
the
01-24-feat_workflows_add_loop_state
branch
from
9412633 to
35b98b9
Compare
This was referenced Jan 24, 2025
NathanFlurry
approved these changes
Jan 27, 2025
Merge activity
|
NathanFlurry
pushed a commit
that referenced
this pull request
Jan 27, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> Fixes RVTEE-573 ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVTEE-573
Changes