Skip to content

chore(sdks/actor/runtime): remove legacy version check #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(sdks/actor/runtime): remove legacy version check #1960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions sdks/actor/runtime/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,6 @@ export class RpcNotFound extends ActorError {
}
}

export class InvalidProtocolVersion extends ActorError {
constructor(version?: string) {
super(
"invalid_protocol_version",
`Invalid protocol version \`${version}\`.`,
{ public: true },
);
}
}

export class InvalidProtocolFormat extends ActorError {
constructor(format?: string) {
super(
Expand Down
9 changes: 0 additions & 9 deletions sdks/actor/runtime/src/inspect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,6 @@ export class ActorInspection<A extends AnyActor> {
}, 500);

handleWebsocketConnection(c: Context): WSEvents<WebSocket> {
// TODO: Compare hub version with protocol version
const protocolVersion = c.req.query("version");
if (protocolVersion !== "1") {
this.#logger.warn("invalid protocol version", {
protocolVersion,
});
throw new errors.InvalidProtocolVersion(protocolVersion);
}

let connection: Connection<A> | undefined;
return {
onOpen: (evt, ws) => {
Expand Down
Loading