Skip to content

Commit

Permalink
8346739: jpackage tests failed after JDK-8345259
Browse files Browse the repository at this point in the history
Reviewed-by: kcr, asemenyuk
  • Loading branch information
Mandy Chung authored and pull[bot] committed Dec 20, 2024
1 parent 61a5927 commit 8346986
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public class RuntimeImageSymbolicLinksTest {

@Test
public static void test() throws Exception {
final Path jmods = Path.of(System.getProperty("java.home"), "jmods");
final Path workDir = TKit.createTempDirectory("runtime").resolve("data");
final Path jlinkOutputDir = workDir.resolve("temp.runtime");
Files.createDirectories(jlinkOutputDir.getParent());
Expand All @@ -61,6 +62,7 @@ public static void test() throws Exception {
.addArguments(
"--output", jlinkOutputDir.toString(),
"--add-modules", "ALL-MODULE-PATH",
"--module-path", jmods.toString(),
"--strip-debug",
"--no-header-files",
"--no-man-pages",
Expand Down
2 changes: 2 additions & 0 deletions test/jdk/tools/jpackage/share/RuntimeImageTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public class RuntimeImageTest {

@Test
public static void test() throws Exception {
final Path jmods = Path.of(System.getProperty("java.home"), "jmods");
final Path workDir = TKit.createTempDirectory("runtime").resolve("data");
final Path jlinkOutputDir = workDir.resolve("temp.runtime");
Files.createDirectories(jlinkOutputDir.getParent());
Expand All @@ -54,6 +55,7 @@ public static void test() throws Exception {
.addArguments(
"--output", jlinkOutputDir.toString(),
"--add-modules", "ALL-MODULE-PATH",
"--module-path", jmods.toString(),
"--strip-debug",
"--no-header-files",
"--no-man-pages",
Expand Down
3 changes: 3 additions & 0 deletions test/jdk/tools/jpackage/share/RuntimePackageTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ private static PackageTest init(Set<PackageType> types) {
.forTypes(types)
.addInitializer(cmd -> {
final Path runtimeImageDir;
final Path jmods = Path.of(System.getProperty("java.home"), "jmods");

if (JPackageCommand.DEFAULT_RUNTIME_IMAGE != null) {
runtimeImageDir = JPackageCommand.DEFAULT_RUNTIME_IMAGE;
} else {
Expand All @@ -112,6 +114,7 @@ private static PackageTest init(Set<PackageType> types) {
.addArguments(
"--output", runtimeImageDir.toString(),
"--add-modules", "ALL-MODULE-PATH",
"--module-path", jmods.toString(),
"--strip-debug",
"--no-header-files",
"--no-man-pages")
Expand Down

0 comments on commit 8346986

Please sign in to comment.