Skip to content

Commit

Permalink
refactor/polish ~ fix ESLint complaint ('no-unused-disable')
Browse files Browse the repository at this point in the history
  • Loading branch information
rivy committed Dec 13, 2020
1 parent 5680208 commit d5b9386
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
3 changes: 2 additions & 1 deletion eg/show-paths.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

// # const path = require('path');
const util = require('util');

const _ = require('lodash') || undefined;

const osPaths = require('..');
Expand All @@ -16,7 +17,7 @@ if (_) {
});
}

process.env.TMPDIR = process.env.TEMP = process.TMP = 'temp'; // eslint-disable-line no-multi-assign
process.env.TMPDIR = process.env.TEMP = process.TMP = 'temp';
if (_) {
_.each(osPaths, (value, key) => {
console.log(key, '=', osPaths[key]());
Expand Down
15 changes: 8 additions & 7 deletions test/unit.test.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
// # spell-checker:ignore UserProfile
/* eslint-env es6, node */
import os from 'os';

import test from 'ava';

import osPaths from '../src/lib';

test('default', (t) => {
const paths = osPaths();

process.env.HOME = process.env.USERPROFILE = 'home'; // eslint-disable-line no-multi-assign
process.env.TMPDIR = process.env.TEMP = process.env.TEMP = 'temp'; // eslint-disable-line no-multi-assign
process.env.HOME = process.env.USERPROFILE = 'home';
process.env.TMPDIR = process.env.TEMP = process.env.TEMP = 'temp';

for (const key of Object.keys(paths)) {
const value = paths[key];
Expand All @@ -24,16 +25,16 @@ test('default', (t) => {

test('alternate construction (via function)', (t) => {
const paths = osPaths();
process.env.HOME = process.env.USERPROFILE = 'home'; // eslint-disable-line no-multi-assign
process.env.HOME = process.env.USERPROFILE = 'home';
t.is(paths.home(), 'home');
});

test('no os.homedir/os.tmpdir', (t) => {
os.homedir = null;
os.tmpdir = null;
const paths = osPaths();
process.env.HOME = process.env.USERPROFILE = 'home'; // eslint-disable-line no-multi-assign
process.env.TEMP = process.env.TMP = process.env.TMPDIR = 'temp'; // eslint-disable-line no-multi-assign
process.env.HOME = process.env.USERPROFILE = 'home';
process.env.TEMP = process.env.TMP = process.env.TMPDIR = 'temp';
t.is(paths.home(), 'home');
t.is(paths.temp(), 'temp');
});
Expand All @@ -42,8 +43,8 @@ test('no os.homedir/os.tmpdir and trailing slash in source', (t) => {
os.homedir = null;
os.tmpdir = null;
const paths = osPaths();
process.env.HOME = process.env.USERPROFILE = 'home/'; // eslint-disable-line no-multi-assign
process.env.TEMP = process.env.TMP = process.env.TMPDIR = 'temp/'; // eslint-disable-line no-multi-assign
process.env.HOME = process.env.USERPROFILE = 'home/';
process.env.TEMP = process.env.TMP = process.env.TMPDIR = 'temp/';
t.is(paths.home(), 'home');
t.is(paths.temp(), 'temp');
});

0 comments on commit d5b9386

Please sign in to comment.