Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPC RZIL tests #75

Merged
merged 74 commits into from
Aug 6, 2022
Merged

PPC RZIL tests #75

merged 74 commits into from
Aug 6, 2022

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Apr 29, 2022 •
edited
Loading

This PR adds the test binaries for the PPC uplifting.
It adds:

  • README with documentation
  • A build script
  • A script to run all rz-tracetests
  • Four binaries
    • asm_tests: Holds all implemented instructions. Disassembly is meant to be copied to rizin/test/db/asm/ppc64
    • pseudo_fuzz_tests: Copy of asm_tests but is compiled to a ELF file and run with QEMU. Each instruction class is given static random data for testing.
    • ppc64le, ppc32be Big and little endian binaries which are meant to test edge cases as well as branch instructions. Should more or less cover all possible execution paths in the RZIL code.

The builds of the ELF binaries are not reproducible. If this is a problem?

@Rot127
Copy link
Member Author

Rot127 commented May 10, 2022 •
edited
Loading

Please do not merge. The binary is currently 17M large. Which is really not necessary.

@Rot127 Rot127 mentioned this pull request May 13, 2022
Merged
5 tasks
@wargio wargio marked this pull request as draft May 24, 2022 19:17
wargio
wargio reviewed Jul 30, 2022
View reviewed changes
elf/ppc/ppc64_fp.S Outdated Show resolved Hide resolved
@Rot127 Rot127 mentioned this pull request Jul 31, 2022
Merged
@Rot127 Rot127 marked this pull request as ready for review July 31, 2022 23:04
@XVilka
Copy link
Member

XVilka commented Aug 6, 2022

@Rot127 GitHub says there is some conflict - please rebase and merge.

@XVilka XVilka requested a review from thestr4ng3r August 6, 2022 16:31
@wargio
Copy link
Member

wargio commented Aug 6, 2022

not to me., but yeah, rebase just in case

@Rot127
Add copyright info
3b99b52
@Rot127
Restructure test binaries.
21afb1a 
* There are now 32be and 64le test binaries
* There are instructions how to compile them and what compile to use.
* Source files has been splitted into 32bit and 64bit where necesssary.
@Rot127
Update binaries
2831fd5
@Rot127
Add load instructions to run_all_tests
54a6c3d
@Rot127
Add remarks about dcbz.
8fb9a6a
@Rot127
Update asm tests.
aacf188
@Rot127
Add binary to pseudo fuzz each implemented instruction.
7c8c5a3
@Rot127
Change asm_insn to match the asm_pseudo_fuzz_tests src file (remove u…
d87805e 
…sage of r30/r31 regs).
@Rot127
Add build command for building asm pseudo fuzz tests.
50a253b
@Rot127
Update binaries.
f7d1af1
@Rot127
Add run all tests script
2480ab2
@Rot127
Run all four random data dumps over all instructions.
247472d
@Rot127
remove asm_pseudo_fuzz_tests.frames
bc99a44
@Rot127
Rename asm_pseudo_fuzz_tests -> pseudo_fuzz_tests
a815e80
@Rot127
Update binaries.
a3dfe26
@Rot127
Add emulate tests.
37be541
@Rot127
Move src files into repos src dir.
7ab59c2
@Rot127
Add 32bit emulateme bins
58144ec
@Rot127
Add emulateme 64bit test binaries.
21ba0d3
@Rot127
Clean up log messages and script
793b2df
@Rot127
Update toolchain description in README and compile emulateme bins wit…
031a1a2 
…h GNU/intel.
@Rot127
Update binaries.
816b974
@Rot127
Copy link
Member Author

Rot127 commented Aug 6, 2022

Probably happened because I pushed to the same branch after it was merged before.

@Rot127
Copy link
Member Author

Rot127 commented Aug 6, 2022

Those two binaries the test fails for should be removed.

@thestr4ng3r
Copy link
Member

Those two binaries the test fails for should be removed.

Why? We have the policy to not allow any removals to prevent breaking tests of older rizin commits.

@Rot127
Copy link
Member Author

Rot127 commented Aug 6, 2022

Why? We have the policy to not allow any removals to prevent breaking tests of older rizin commits.

I added these binaries for testing in the beginning of rizinorg/rizin#2823 but quickly stopped using them. Those two were merged in #73 and #72 before rizinorg/rizin#2823 was ready for review. The current PPC RZIL tests don't use them anymore.

If rizinorg/rizin#2823 is squashed there will be no commit which uses them.

thestr4ng3r
thestr4ng3r approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then lgtm.

@wargio wargio merged commit 7d0c31a into master Aug 6, 2022
@wargio wargio deleted the ppc-il-tests branch August 6, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@thestr4ng3r thestr4ng3r thestr4ng3r approved these changes

@XVilka XVilka XVilka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rot127 @XVilka @wargio @thestr4ng3r