You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, both modes are implemented completely independently, sometimes with code duplication/copy-paste.
I propose to reduce the code and feature duplication by:
Only after the three above are finished, determine what code is logically/semantically share by both and extract it into other file or RzCons or RzUtils.
Determine what features overlap, and consider the merge of both modes.
Please note, that many features that are present in Visual mode are missing in the Panels mode, and there is a significant difference how these modes operate:
Visual mode has the concept of rotation - press p/P to switch between representations
Panels mode has the concept of panes and useful for custom arrangement.
Thus, we might consider keeping the both modes as is from the user point of view, but reduce the code and feature duplication to the minimum.
The text was updated successfully, but these errors were encountered:
I think this is not going to happen anytime "soon" and by soon I mean at least a year, considering the many projects we have opened right now. I propose to close this issue for now as a way to try to keep the list of issues manageable.
Currently, both modes are implemented completely independently, sometimes with code duplication/copy-paste.
I propose to reduce the code and feature duplication by:
librz/core/tui/visual.c
) to use API instead of commands #382librz/core/tui/panels.c
) to use API instead of commands #383/librz/core/tui/vmenus*
to use API instead of commands #491Please note, that many features that are present in Visual mode are missing in the Panels mode, and there is a significant difference how these modes operate:
p
/P
to switch between representationsThus, we might consider keeping the both modes as is from the user point of view, but reduce the code and feature duplication to the minimum.
The text was updated successfully, but these errors were encountered: