Some default panels broken

[imyxh]

Work environment

Questions	Answers
OS/arch/bits (mandatory)	Linux 6.4.1-arch2-1 x86_64
File format of the file you reverse (mandatory)	any
Architecture/bits of the file (mandatory)	any
rizin -v full output, not truncated (mandatory)	rizin 0.6.0 @ linux-x86-64 (not printed: commit 83e40b0)

Expected behavior

The default panels in visual panels mode should work.

Actual behavior

"Stack" and any other panels using px commands are broken for some reason. The default command for "Stack" is pxq 256@r:SP which runs fine on its own but not in the panel. Changing the command (using the " key) to pxq 256@r:SP again makes the window say pxq 256@r:SP (xc 256@r:SP) which seems to work fine but also prints the results of xc, not pxq. Changing the command to xc 256@r:SP works as intended.

The "Registers" command is out of date and should be %== true `e cfg.debug`; %! dr; %% ar. Changing it to this works fine.

Steps to reproduce the behavior

Open anything with -d and check V!

Additional Logs, screenshots, source code, configuration dump, ...

[imyxh]

I can submit a PR for the quick fix at imyxh@755535f if you wish but it makes more sense to figure out what's going on with px first

[wargio]

could you test my fix?

[imyxh]

could you test my fix?

Works fine for me! It's blank when not in debug mode whereas the old code did ar but I don't think it matters much. It's probably nicer to have the command shorter like this.

That being said, although changing the default panels fixes the issue at a glance (already did this in imyxh@755535f) I'm still worried about why px doesn't work and if that's pointing to some deeper problem.

[wargio]

the reason why it doesn't work using px is because the default output is xc not px.
All the panels should be ported to use the C code and many things should be removed from there.

[XVilka]

the reason why it doesn't work using px is because the default output is xc not px. All the panels should be ported to use the C code and many things should be removed from there.

Right, a bunch of code can be shared between "classic" visual mode and panels: #384