-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default libuv from 1.40.0 to 1.42.0 #1628
Conversation
Please add the lib here: https://github.com/rizinorg/fallback-repo |
|
This is |
That means we won't be able to compile rizin on win7 anymore? |
i have uploaded the targz to the fallback repo |
|
@XVilka probably you just need to fix a bit the meson.build file of the libuv subproject, which was created by me AFAIR. For example, |
Let's wait first until libuv/libuv#3285 get merged then. |
As libuv is doing nothing on addressing the Windows 7 compatibility regression, I propose to take the patch from libuv/libuv#3285 and apply using Meson as we did for tree-sitter, for example. |
Your checklist for this pull request
Detailed description
1.40.0 is very old version, new version has a few important Windows and BSD bugfixes:
Changes since version 1.40.0:
-Wincompatible-pointer-types
warning (Ben Noordhuis)-Wsign-compare
warning (Ben Noordhuis)-fno-strict-aliasing
(Ben Noordhuis)timeout
field (Ben Noordhuis)Changes since version 1.41.0:
See more at:
Please note, that this will require Windows 8 at least. On the other hand, the Windows 7 builds will be still possible with previous version.
Test plan
CI is green