Fix oob write for dwarf with abbrev with count 0 (Fix #2083) #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
requested review from
kazarmy,
ret2libc,
wargio and
XVilka
as code owners
ret2libc
reviewed
Dec 10, 2021
| die->attr_values = calloc(sizeof(RzBinDwarfAttrValue), attr_count); | ||
| if (!die->attr_values) { | ||
| return -1; | ||
| if (attr_count) { |
There was a problem hiding this comment.
Is this check really necessary? Isn't checking for ->capacity in the various uses enough?
Also, this is init_die function, is it alright to have die->attr_values potentially not initialized? (i didn't check if the caller already initialize it).
There was a problem hiding this comment.
No, it is not strictly required. It only affects whether we then have NULL or whatever calloc() gives for a zero size. I kind of prefer the former.
thestr4ng3r
force-pushed
the
dwarf-empty
branch
from
88fc57b to
a1dc23b
Compare
XVilka
approved these changes
Dec 10, 2021
wargio
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Fix #2083
Detailed description
This is described in #2083.