[WIP] PPC uplifting #2497
Closed
[WIP] PPC uplifting #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
reviewed
Apr 7, 2022
wargio
reviewed
Apr 14, 2022
This was referenced Apr 16, 2022
XVilka
reviewed
Apr 24, 2022
XVilka
requested changes
Apr 24, 2022
thestr4ng3r
reviewed
Apr 24, 2022
* Add vector registers. * Remove 32bit ver. (is subset of 64bit). * Use new register types (vector, control)
* add * addc * adde * addi * addic * addis * addme * addze
|
you should really rebase |
|
Rebasing forces me to solve a conflict every 10 commits or so :( Is there any trick? Otherwise I just open a new PR. |
Merged
|
Superseded by #2823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Bugs
Rough roadmap
Most common instructions are implemented and tested. (common = >=1% occurrence in libc, libglib, libslang etc.)NOPedsrawsetca,ca32CMDB,EQV,DCBZ,MTXER,DIV,MULNeeds new il effects which allow to iterate over certain global vars.Some todos
ppc_prefix or without. But not both.TODOs after merge
dcbzinstruction zeros a cache line/block. The size of this line depends on the PPC implementation (ESIL hardcodes it to 128. RZIL to 32). It should be replaced with a plugin config option once RzArch is done.Also, if this PR is merged before RzArch, an issue should be opened.