Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosmetic changes from cris-dis.c #3120

Merged
merged 8 commits into from
Oct 24, 2022

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 23, 2022

SQUASH

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr removes cosmetic changes from librz/asm/arch/cris/gnu/cris-dis.c so that it's closer to upstream and thus easier to merge changes from upstream. The removal process involves git reset -p and a lot of looking at code hunks, splitting them when necessary.

Test plan

The changes are cosmetic. All builds are green.

Closing issues

...

@wargio
Copy link
Member

wargio commented Oct 23, 2022

is this PR ready to be reviewed?

@wargio wargio requested a review from ret2libc October 23, 2022 22:45
@kazarmy
Copy link
Member Author

kazarmy commented Oct 23, 2022

emm yes

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these cosmetics changes looks weird to me, but the code looks the same.

@kazarmy
Copy link
Member Author

kazarmy commented Oct 24, 2022

unsure which ones look weird

@kazarmy kazarmy merged commit 2957d60 into rizinorg:dev Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants