RzList to RzPVector shift in RzAnalysisSwitchOp #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HN026
requested review from
thestr4ng3r,
wargio,
XVilka,
kazarmy and
ret2libc
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
wargio
reviewed
Dec 8, 2023
wargio
reviewed
Dec 8, 2023
XVilka
requested changes
Dec 8, 2023
There was a problem hiding this comment.
With ASAN you can see the reason why many tests fail:
[XX] db/abi/platforms/main_signatures MAIN_ABI : mips64-linux-gnueabi main
RZ_NOPLUGINS=1 /home/runner/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -A -Qc 'e scr.utf8=false
s main
afs @ main
' bins/abi_bins/elf/platforms/mips64-linux-gnueabi-echo
-- stdout
--- expected
+++ actual
@@ -1,1 +1,0 @@
-int main(int argc, char **argv, char **envp);
-- stderr
[ ] Analyze all flags starting with sym. and entry0 (aa)
[
[x] Analyze all flags starting with sym. and entry0 (aa)
[ ] Analyze function calls
[
[x] Analyze function calls
[ ] find and analyze function preludes
[
[x] find and analyze function preludes
[ ] Analyze len bytes of instructions for references
[
[x] Analyze len bytes of instructions for references
[ ] Check for classes
[
[x] Check for classes
[x] Finding xrefs in noncode section with analysis.in=io.maps
[x] Analyze value pointers (aav)
[x] Value from 0x120000000 to 0x120001514 (aav)
[x] 0x120000000-0x120001514 in 0x120000000-0x120001514 (aav)
[ ] Emulate functions to find computed references
[../librz/include/rz_vector.h:270:28: runtime error: applying non-zero offset 18446744073709551600 to null pointer
AddressSanitizer:DEADLYSIGNAL
=================================================================
==64086==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x7fe85f897f4e bp 0x7ffc03d82f50 sp 0x7ffc03d82120 T0)
==64086==The signal is caused by a READ memory access.
==64086==Hint: this fault was caused by a dereference of a high value address (see register values below). Disassemble the provided pc to learn which register was used.
#0 0x7fe85f897f4e in rz_pvector_at ../librz/include/rz_vector.h:270
#1 0x7fe85f897f4e in get_next_i ../librz/core/canalysis.c:3310
#2 0x7fe85f897f4e in rz_core_analysis_esil ../librz/core/canalysis.c:3685
#3 0x7fe85f990bf2 in rz_core_analysis_esil_references_all_functions ../librz/core/cil.c:296
#4 0x7fe85f8b81a0 in rz_core_analysis_everything ../librz/core/canalysis.c:4826
#5 0x7fe85f8ba15f in rz_core_perform_auto_analysis ../librz/core/canalysis.c:6521
#6 0x7fe869d0a528 in rz_main_rizin ../librz/main/rizin.c:1379
#7 0x7fe869229d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)
#8 0x7fe869229e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: 203de0ae33b53fee1578b117cb4123e85d0534f0)
#9 0x56538e3ffb04 in _start (/home/runner/bin/rizin+0x2b04) (BuildId: 6cbc57462e9936c4a87c6b5769a61799e0a240d6)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV ../librz/include/rz_vector.h:270 in rz_pvector_at
==64086==ABORTING
-- exit status: 1
You can try to import this commit: 42a3fb7 cc @imbillow
You can try to send a PR with that change separately too @imbillow
* PDB: add module info parsing * Refactor PDB component * Refactor PDB/tpi * Fix read_pascal_string * Fix memory leaks * Add test `Modules from PDB`
wargio
reviewed
Dec 14, 2023
wargio
reviewed
Dec 14, 2023
|
looks like a lot of stuff is broken. |
Yes, the issue persists. I tried added additional checks but no help |
it is not because of the checks but because you changed the logic behind it. i suspect the main issue is related to how the new code works with the switch cases. |
wargio
reviewed
Dec 15, 2023
librz/core/canalysis.c
Outdated
Comment on lines
380
to
381
| if (bb->switch_op) { | ||
| RzList *unique_cases = rz_list_uniq(bb->switch_op->cases, casecmp); | ||
| outputs += rz_list_length(unique_cases); | ||
| rz_list_free(unique_cases); | ||
| if (bb->switch_op) { |
There was a problem hiding this comment.
looks like you also have dup this check.
There was a problem hiding this comment.
Argh, that's a mistake by my side. Apologies.
wargio
reviewed
Dec 15, 2023
wargio
reviewed
Dec 15, 2023
wargio
requested changes
Dec 16, 2023
|
@HN026 now that refactoring has landed, please rebase your PR (and fix corresponding conflicts) |
|
not yet. the code i want to refactor is not yet done. that PR was one of many |
Okay I've already done it once for now. Inform me when you're done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Partially addresses #3872