Add rz_vector_assign_at() #4373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
ret2libc,
thestr4ng3r,
wargio,
XVilka and
kazarmy
as code owners
wargio
reviewed
Mar 22, 2024
| * | ||
| * \return The pointer stored at \p index before. Or NULL in case of failure. | ||
| */ | ||
| RZ_API void *rz_pvector_assign_at(RZ_BORROW RZ_NONNULL RzPVector *vec, size_t index, RZ_OWN RZ_NONNULL void *ptr) { |
There was a problem hiding this comment.
why you need this when rz_pvector_set is available?
There was a problem hiding this comment.
rz_pvector_set is private. My thinking was, that it is better to have an equivalent function to the normal rz_vector_assign_at. So we don't mix up names with function between RzVector and RzPVector.
There was a problem hiding this comment.
well, it's an inline within the headers.
There was a problem hiding this comment.
Something is wrong with this week -.-
Yeah, it is not necessary to add it than. rz_pvector_get and rz_pvector_set is good enough. Let me close this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Adds a
rz_vector_assign_at()function.Test plan
Added.
Closing issues
...