Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrap for native SoftFloat subproject and use the native dep #4605

Closed
wants to merge 1 commit into from

Conversation

DMaroo
Copy link
Member

@DMaroo DMaroo commented Sep 4, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

The top-level meson file now uses the native SoftFloat dependency is the project is being cross-compiled. Using the cross-native branch of SoftFloat for native subproject. This ought to fix the issue raised in #4604 (comment).

To understand why this works, have a look at this commit.

Test plan

Android build should be green.

Closing issues

Related PR: #4593.

    * The top-level meson file now uses the native SoftFloat dependency
      is the project is being cross-compiled
@DMaroo
Copy link
Member Author

DMaroo commented Sep 4, 2024

Sending it from a dist- branch.

@DMaroo DMaroo closed this Sep 4, 2024
@wargio wargio deleted the fix-softfloat-native-build branch September 4, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant