Refactor: Use HtSP for storing plugins. #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves iterations when searching for a plugin of a given name. It also allows to save plugin configurations and data in hash table, all addressed by their name. Hence, usage is more streamlined.
If arch is passed on from another struct, NULL is an allowed invalid value.
Rot127
requested review from
ret2libc,
thestr4ng3r,
wargio,
yossizap,
XVilka and
kazarmy
as code owners
github-actions
bot
added
rz-test
RzIO
RzBin
RzAnalysis
RzDebug
API
RzCore
RzCrypto
RzEgg
RzUtil
rz-hash
rz-gg
RzHash
RzBreakpoint
labels
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Rot127
force-pushed
the
plugin-management
branch
from
eb38122
to
a2019d7
Compare
XVilka
approved these changes
Oct 25, 2024
Rot127
force-pushed
the
plugin-management
branch
from
a2019d7
to
56d1831
Compare
wargio
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Refactor: Use
HtSPfor storing plugins.This saves iterations when searching for a plugin of a given name. It also allows to save plugin configurations and data in hash table, all addressed by their name. Hence, usage is more streamlined.
Test plan
All green
Closing issues
...