Use relocation types name defined by each bin format. #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roeegg2
requested review from
ret2libc,
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
Rot127
requested changes
Nov 3, 2024
wargio
reviewed
Nov 3, 2024
wargio
changed the title
Roeegg2
force-pushed
the
reloc-naming
branch
3 times, most recently
from
d89eb12
to
a9853a5
Compare
Rot127
requested changes
Nov 3, 2024
* Modified `bin_reloc_type_name` to return correct naming if possible, otherwise return the old ADD/SET naming. * Add `print_name` field to `RzBinReloc`
* Fixed the relocation names in the regression tests
|
@Rot127 done |
Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>
wargio
reviewed
Nov 4, 2024
wargio
reviewed
Nov 4, 2024
|
@XVilka muon seems broken? |
No, just a small name change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
bin_reloc_type_nameto return correct naming if possible, otherwise return the oldADD/SETnaming.RzBinRelocEvery relocation is being assigned a type based off whether it needs an addend added to it or not (
SETfor no addend,ADDfor with). This is whatRzBinReloc.additivewas for.RzBinReloc.typehas just been the bit size of the relocationAnd the final name of the relocation printed was just a combination of the both (which is wrong)
In order to not break all the other relocation types, I haven't removed the old code completely yet. When all the other executable formats support the new printing I'll remove it completely.
...
Test plan
All tests green
...
Closing issues
...