Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't globally override text and background color in dark theme #4020

Closed
artar94 opened this issue Mar 13, 2022 · 8 comments
Closed

Can't globally override text and background color in dark theme #4020

artar94 opened this issue Mar 13, 2022 · 8 comments
Labels

Comments

@artar94
Copy link
Contributor

artar94 commented Mar 13, 2022

When using the dark theme, all schemes (Text Files, Apache Config Files, etc.) have the default style fore:#DEDEDE; back:#141414.
The definition of fore and back in Coomon Base has no effect and must be explicitly redefined in each schema.
image
The problem is observed in stable version 5.21.1129.1 and in beta version 5.22.302.1.
The problem does not reoccur in the white theme.

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 14, 2022

Hello @artar94 ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.414.1_beta.paf" or newer, see 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.414.1_beta_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

@artar94
Copy link
Contributor Author

artar94 commented Apr 14, 2022

Hello!

Now it works better, but the problem with Text Files remains.
Now Text Files get font:$Text style by default.
If you select any other scheme and return to Text Files, the style will change to font:Segoe UI.
All other schemes work correctly.
image

I also noticed this little problem:
image

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 15, 2022

Hello @artar94 ,

Well, I recommend : 🤔

More About Cascadia Code: https://github.com/microsoft/cascadia-code,

@artar94
Copy link
Contributor Author

artar94 commented Apr 15, 2022

I'm sorry, but I don't understand why I need to install new fonts.
I tried installing the latest beta on a clean system and the problem persists.
Maybe I didn't express myself correctly. The problem is not in Segoe UI, but in the fact that style inheritance does not work predictably. My sequence of actions:

  1. Open text document (I see the Segoe UI font)
  2. Click Appearence -> Customize Schemes (In Text Files - Default Style it says font:$Text)
  3. I clear the field Text Files - Default Style and click OK
  4. Now I see Consolas as expected (I configured Consolas in Common Base schema)
  5. Close Notepad3 (Settings are saved)
  6. I reopen the text document and see Segoe UI and font:$Text again. The problem is exactly this, my setting in step 3 was discarded.

I would expect that the cleared Text Files - Default Style field would simply inherit the value from Common Base, and not be replaced by the magic constant font:$Text. Maybe this constant should be present in Notepad3.ini out of the box? Then clearing Text Files - Default Style will work as expected.

@craigo-
Copy link

craigo- commented Apr 27, 2022

Yep, I'm seeing some new odd behaviour in the Text Files lexer UI too, that is present in the latest beta (5.22.418.1 beta).

(I hope I'm not repeating already-known oddities...)

  1. In a freshly unpacked version, select Appearance -> Customize Schemes.... Note that the "Text Files" scheme's default style is "font:$Text".
  2. Select the "Common Base" scheme.
  3. Select the "Text Files" scheme. Note that the "Text Files" scheme's default style has changed to "font:Segoe UI".
  4. Click OK to close the Scheme dialogue
  5. Select Appearance -> Customize Schemes.... Note that the "Text Files" scheme's default style remains as "font:Segoe UI".
  6. Click OK to close the Scheme dialogue
  7. Close and relaunch Notepad3.
  8. Select Appearance -> Customize Schemes.... Note that the "Text Files" scheme's default style has changed to "font:$Text".

...And I can confirm the findings of @artar94 that removing the default style for the "Text Files" style, such that it again inherits the style defined in Common Base, only lasts until Notepad3 is closed and relaunched. Afterwards it reverts back to "font:$Text" / font:Segoe UI".

I am also very used to the "Text Files" scheme inheriting the base font from "Common Base" (or "2nd Common Base"). I am not particularly liking that the "Text Files" scheme now has its own font definition. There is currently only one other scheme that defines a different font: "ANSI Art", for fairly obvious glyph-based reasons. What was the reason for moving to a defined font for the "Text Files" scheme?

@hpwamr
Copy link
Collaborator

hpwamr commented Apr 30, 2022

I confirm with Windows 7 SP1, the Font: for Text Files: Default Style is --> "Segoe UI" ! 😬

2022-04-30_100435

@hpwamr
Copy link
Collaborator

hpwamr commented May 2, 2022

would expect that the cleared Text Files - Default Style field would simply inherit the value from Common Base, and not be replaced by the magic constant font:$Text.

am also very used to the "Text Files" scheme inheriting the base font from "Common Base" (or "2nd Common Base"). I am not particularly liking that the "Text Files" scheme now has its own font definition. There is currently only one other scheme that defines a different font: "ANSI Art", for fairly obvious glyph-based reasons. What was the reason for moving to a defined font for the "Text Files" scheme?

I agree, the "Text Files" scheme should inherit the base font from "Common Base" (or "2nd Common Base"). 😏


Hello @artar94 , @craigo- ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_5.22.502.1_beta.paf" or newer, see 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_5.22.502.1_beta_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

@artar94
Copy link
Contributor Author

artar94 commented May 2, 2022

Now everything works as I expected, thank you very much for your work!

@artar94 artar94 closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants