Replace lazy_static with OnceLock #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tamaroning , thanks for this PR. I was not aware of the I like that idea to not depending another crate for this. But was looking to the LazyLock, which has similar semantic as |
|
I did not know about LazyLock since it was added to the standard library very recently. |
tamaroning
force-pushed
the
fix/lazy-static
branch
from
8b51c09
to
d7d8ed5
Compare
|
fixed |
|
Thanks @tamaroning , fantastic speed! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am glad to know that bear is being rewritten in Rust and it sounds interesting.
This patch removes uses of lazy_static since it is going to be deprecated (see rust-lang-nursery/lazy-static.rs#214). The std library now supports OnceCell and OnceLock as alternatives.