Move cgo files to main package directory #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a specific error for out of date hashes
This introduces a new fsLock that will lock around both the updates and the file system effects to allow code reading from the tries to make forward motion while preventing other filesystem modifications at the same time. It also moves the updateLock to updateLookupMap. Depending on how heavy the trie operations are in updateLookupMap and how large the tries get, we may want to either a) clone the tries and then pointer swap them in or b) make the locks occur only around each exact operation. For instance, in the PREFIX_4B_SZ, CHUNK_TYPE_SUB case, we could allow the Lookup.Delete to occur in a write lock, take a read lock to pull the data from the FullHashes iterator, and only then go back with a write lock around with a write lock around each individual FullHashes.Delete. Since all of this happens under fsLock, we don't have worry about multiple SafeBrowsingList.load calls stomping on each other's toes.
only lock updates around the actual update
update to the latest rjohnsondev/master
Per tools/godep#422, godep won't find cgo files in other directories, so vendoring won't work without this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per tools/godep#422, godep won't find cgo files in other directories, so this fix is required for vendoring to work properly.