Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* react-dom is external peerDependency, just like react. fixes version conflicts, e.g. I got an error Uncaught TypeError: this.updater.enqueueCallback is not a function when using setState callback because I use React 16.x and react-jsonschema-form bundled react-dom 15.x See facebook/react#10320 (comment) * Fix for new submit() method (PR #1058) also submitting the HTML form ..., navigating away from current page at least in Firefox. Reason: dispatched event was not cancelable, so preventDefault in onSubmit couldn't cancel it. Links: * <https://stackoverflow.com/a/40916998> * <https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable> * Synchronous call to onSubmit() from props Due to the use of setImmediate() hack in setState utility function (utils.js), onSubmit() handler from props is called asynchronously. This leads to massive problems for operations requiring "trusted events", like window.open() or programmatically submitting forms with target "_blank" (which we needed) Because onSubmit() should not need the performance-related setImmiate() hack, I replaced call to setState utility function with proper this.setState() from React. * fix failing FileWidget tests by changing to proper use of setState() without setImmediate() hacks (see #1197) * fix input type, fix test name * Test with newer node versions * Add node 12
- Loading branch information